Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Docker.md #1554

Merged
merged 1 commit into from
Feb 6, 2024
Merged

Update Docker.md #1554

merged 1 commit into from
Feb 6, 2024

Conversation

abhaymathur21
Copy link
Contributor

@abhaymathur21 abhaymathur21 commented Feb 6, 2024

Location of dockerfiles was changed from samples to .devcontainer but not updated in these website docs for docker

  • I changed the link so it points to the actual location of the docker files

Why are these changes needed?

When I was reading the docs for the docker section, I had a hard time finding the dockerfiles the docs were referring to because the link given doesn't lead you to the actual dockerfiles anymore. This solves this problem and will prevent other people reading the docs from facing this issue again.

Related issue number

Checks

Location of dockerfiles was changed from samples to but not updated in these website docs for docker

- I changed the link so it points to the actual location of the docker files
@codecov-commenter
Copy link

codecov-commenter commented Feb 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c603ca4) 35.02% compared to head (d30252a) 35.02%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1554   +/-   ##
=======================================
  Coverage   35.02%   35.02%           
=======================================
  Files          43       43           
  Lines        5207     5207           
  Branches     1211     1211           
=======================================
  Hits         1824     1824           
  Misses       3231     3231           
  Partials      152      152           
Flag Coverage Δ
unittests 35.02% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sonichi sonichi added this pull request to the merge queue Feb 6, 2024
Merged via the queue into microsoft:main with commit 6f8ccf8 Feb 6, 2024
19 checks passed
whiskyboy pushed a commit to whiskyboy/autogen that referenced this pull request Apr 17, 2024
Location of dockerfiles was changed from samples to but not updated in these website docs for docker

- I changed the link so it points to the actual location of the docker files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants