Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable default code execution on society_of_mind and web_surfer. #1516

Merged
merged 3 commits into from
Feb 2, 2024

Conversation

afourney
Copy link
Member

@afourney afourney commented Feb 2, 2024

Why are these changes needed?

These are special-purpose agents are not generally intended to execute code. code_execution_config now defaults to False rather than None. This can be overridden by the user.

Checks

@codecov-commenter
Copy link

codecov-commenter commented Feb 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b0c1f8d) 33.12% compared to head (e0c4d19) 45.65%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1516       +/-   ##
===========================================
+ Coverage   33.12%   45.65%   +12.53%     
===========================================
  Files          42       42               
  Lines        5051     5051               
  Branches     1157     1224       +67     
===========================================
+ Hits         1673     2306      +633     
+ Misses       3250     2561      -689     
- Partials      128      184       +56     
Flag Coverage Δ
unittests 45.55% <ø> (+12.47%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sonichi sonichi enabled auto-merge February 2, 2024 23:01
@sonichi sonichi added this pull request to the merge queue Feb 2, 2024
Merged via the queue into main with commit b9bb0ee Feb 2, 2024
46 of 56 checks passed
@sonichi sonichi deleted the disable_code_execution_on_some_agents branch February 4, 2024 00:59
whiskyboy pushed a commit to whiskyboy/autogen that referenced this pull request Apr 17, 2024
…crosoft#1516)

* Disable default code execution on society_of_mind and web_surfer.

* Update autogen/agentchat/contrib/society_of_mind_agent.py

Co-authored-by: Eric Zhu <[email protected]>

* Update autogen/agentchat/contrib/web_surfer.py

Co-authored-by: Eric Zhu <[email protected]>

---------

Co-authored-by: Eric Zhu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants