Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Contribute.md, #1502 #1508

Merged
merged 1 commit into from
Feb 2, 2024

Conversation

victordibia
Copy link
Collaborator

Update to add note on quarto render for website

Why are these changes needed?

Related issue number

#1502

Checks

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5eaf712) 33.08% compared to head (62ceb44) 31.53%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1508      +/-   ##
==========================================
- Coverage   33.08%   31.53%   -1.55%     
==========================================
  Files          42       42              
  Lines        5048     5048              
  Branches     1156     1156              
==========================================
- Hits         1670     1592      -78     
- Misses       3250     3332      +82     
+ Partials      128      124       -4     
Flag Coverage Δ
unittests 31.53% <ø> (-1.51%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gagb
Copy link
Collaborator

gagb commented Feb 1, 2024

Should instruction be at two places @victordibia and @jackgerrits ? Rn it's in both README and Contribute of the website. Probably better for us in the long run to have them at a single place?

@jackgerrits
Copy link
Member

Should instruction be at two places @victordibia and @jackgerrits ? Rn it's in both README and Contribute of the website. Probably better for us in the long run to have them at a single place?

I agree with that - I missed it maybe for that reason

@gagb gagb self-requested a review February 2, 2024 00:47
Copy link
Collaborator

@gagb gagb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's get this merged to at least not cause build error confusions. And create a new issue to remove redundant instructions.

@sonichi sonichi added this pull request to the merge queue Feb 2, 2024
Merged via the queue into main with commit 043c7f9 Feb 2, 2024
22 checks passed
@victordibia victordibia deleted the add-quarto-render-to-website-contribution-docs branch February 6, 2024 18:21
whiskyboy pushed a commit to whiskyboy/autogen that referenced this pull request Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants