-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update tests for code_utils and use ThreadPoolExecutor for code execution in windows #1472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1472 +/- ##
===========================================
+ Coverage 34.30% 46.58% +12.28%
===========================================
Files 42 42
Lines 5110 5102 -8
Branches 1169 1236 +67
===========================================
+ Hits 1753 2377 +624
+ Misses 3213 2524 -689
- Partials 144 201 +57
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
whiskyboy
pushed a commit
to whiskyboy/autogen
that referenced
this pull request
Apr 17, 2024
…tion in windows (microsoft#1472) * threadpoolexecutor * update tests * update tests * fix tests on windows * fix test * update tests * update tests * update tests * update tests * update tests * update tests * fix build.yml * build yaml * test * use skip-docker to explicitly skipping docker tests * update tests * contribution doc update * Update website/docs/Contribute.md Co-authored-by: Chi Wang <[email protected]> * update doc --------- Co-authored-by: Chi Wang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
AutoGen loves windows.
test_execute_code
test. Remove try-catch blocks aroundimport docker
as it is now a core dependency.--skip-docker
to explicitly skip docker-related tests whereuse_docker=True
, avoiding the docker server problem on GitHub action's window instances.env
setting inbuild.yml
workflow file as it is the standard.Related issue number
#1277
Checks