Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tests for code_utils and use ThreadPoolExecutor for code execution in windows #1472

Merged
merged 23 commits into from
Feb 4, 2024

Conversation

ekzhu
Copy link
Collaborator

@ekzhu ekzhu commented Jan 30, 2024

Why are these changes needed?

AutoGen loves windows.

  1. Address This MICROSOFT AUTOGEN was built and made for Mac ONLY ... Nothing works on Windows. SIGALRM is not even compatible with WINDOWS. #1277. Use ThreadPoolExecutor on Windows as well.
  2. Clean up the test_execute_code test. Remove try-catch blocks around import docker as it is now a core dependency.
  3. Use --skip-docker to explicitly skip docker-related tests where use_docker=True, avoiding the docker server problem on GitHub action's window instances.
  4. Use env setting in build.yml workflow file as it is the standard.

Related issue number

#1277

Checks

@codecov-commenter
Copy link

codecov-commenter commented Jan 30, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (392d381) 34.30% compared to head (f879ada) 46.58%.

Files Patch % Lines
autogen/code_utils.py 88.88% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1472       +/-   ##
===========================================
+ Coverage   34.30%   46.58%   +12.28%     
===========================================
  Files          42       42               
  Lines        5110     5102        -8     
  Branches     1169     1236       +67     
===========================================
+ Hits         1753     2377      +624     
+ Misses       3213     2524      -689     
- Partials      144      201       +57     
Flag Coverage Δ
unittests 46.55% <88.88%> (+12.28%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sonichi sonichi disabled auto-merge February 4, 2024 15:07
@sonichi sonichi enabled auto-merge February 4, 2024 15:07
@sonichi sonichi added this pull request to the merge queue Feb 4, 2024
Merged via the queue into microsoft:main with commit 1abbcf3 Feb 4, 2024
43 of 53 checks passed
whiskyboy pushed a commit to whiskyboy/autogen that referenced this pull request Apr 17, 2024
…tion in windows (microsoft#1472)

* threadpoolexecutor

* update tests

* update tests

* fix tests on windows

* fix test

* update tests

* update tests

* update tests

* update tests

* update tests

* update tests

* fix build.yml

* build yaml

* test

* use skip-docker to explicitly skipping docker tests

* update tests

* contribution doc update

* Update website/docs/Contribute.md

Co-authored-by: Chi Wang <[email protected]>

* update doc

---------

Co-authored-by: Chi Wang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants