Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed "Tool Call Id" from main content string. #1471

Merged
merged 2 commits into from
Jan 30, 2024
Merged

Removed "Tool Call Id" from main content string. #1471

merged 2 commits into from
Jan 30, 2024

Conversation

afourney
Copy link
Member

Why are these changes needed?

Closes #1455

Checks

Copy link
Collaborator

@ekzhu ekzhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think test in the test_tool_calls.py needs to be updated.

@afourney
Copy link
Member Author

afourney commented Jan 30, 2024

I think test in the test_tool_calls.py needs to be updated.

Yup. Forgot that file. On it.

@afourney afourney requested a review from ekzhu January 30, 2024 18:58
@codecov-commenter
Copy link

codecov-commenter commented Jan 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2467e97) 33.19% compared to head (2f3bf53) 45.95%.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1471       +/-   ##
===========================================
+ Coverage   33.19%   45.95%   +12.76%     
===========================================
  Files          41       41               
  Lines        4950     4948        -2     
  Branches     1135     1201       +66     
===========================================
+ Hits         1643     2274      +631     
+ Misses       3177     2488      -689     
- Partials      130      186       +56     
Flag Coverage Δ
unittests 45.87% <100.00%> (+12.72%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sonichi sonichi added this pull request to the merge queue Jan 30, 2024
Merged via the queue into main with commit 8d1d073 Jan 30, 2024
49 of 56 checks passed
@sonichi sonichi mentioned this pull request Jan 30, 2024
3 tasks
@afourney afourney deleted the i1455 branch February 6, 2024 17:34
whiskyboy pushed a commit to whiskyboy/autogen that referenced this pull request Apr 17, 2024
* Removed Tool Call Id from main content string.

* Fixed tests.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: When tools are used, the Tool Id is unnecessarily prepended to the message.
5 participants