Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FAQ, working with LLM endpoints and explaining why config-list is a list #1451

Merged
merged 7 commits into from
Jan 30, 2024
Merged

FAQ, working with LLM endpoints and explaining why config-list is a list #1451

merged 7 commits into from
Jan 30, 2024

Conversation

maxim-saplin
Copy link
Collaborator

Making the docs clearer about how LLM API endpoint config works.

Related issue number

Closes #749 and #97

Checks

@gagb gagb added the documentation Improvements or additions to documentation label Jan 29, 2024
@gagb gagb self-requested a review January 29, 2024 22:06
Copy link
Collaborator

@gagb gagb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice clarifications. Thank you for the contributions!

notebook/oai_openai_utils.ipynb Outdated Show resolved Hide resolved
website/docs/FAQ.md Outdated Show resolved Hide resolved
website/docs/FAQ.md Outdated Show resolved Hide resolved
website/docs/FAQ.md Outdated Show resolved Hide resolved
website/docs/FAQ.md Outdated Show resolved Hide resolved
@sonichi sonichi added oai_config_list models Pertains to using alternate, non-GPT, models (e.g., local models, llama, etc.) labels Jan 29, 2024
Copy link
Collaborator

@AaronWard AaronWard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@maxim-saplin Looks great, nice clarifications given especially with describing how the models are chosen in sequence. I just wrote a few minor comments. When those and the typo's @sonichi mentioned i'm happy to approve 👍

website/docs/FAQ.md Outdated Show resolved Hide resolved
website/docs/FAQ.md Outdated Show resolved Hide resolved
website/docs/FAQ.md Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Jan 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6cf5bb0) 33.19% compared to head (5d1e6e2) 33.19%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1451   +/-   ##
=======================================
  Coverage   33.19%   33.19%           
=======================================
  Files          41       41           
  Lines        4950     4950           
  Branches     1135     1135           
=======================================
  Hits         1643     1643           
  Misses       3177     3177           
  Partials      130      130           
Flag Coverage Δ
unittests 33.15% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@maxim-saplin
Copy link
Collaborator Author

@AaronWard , @sonichi please check the update

Copy link
Collaborator

@AaronWard AaronWard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💯

@sonichi sonichi added this pull request to the merge queue Jan 30, 2024
Merged via the queue into microsoft:main with commit 74a4d70 Jan 30, 2024
19 checks passed
whiskyboy pushed a commit to whiskyboy/autogen that referenced this pull request Apr 17, 2024
…ist (microsoft#1451)

* FAQ and notebook extended

* Update notebook/oai_openai_utils.ipynb

Co-authored-by: Chi Wang <[email protected]>

* Update website/docs/FAQ.md

Co-authored-by: Chi Wang <[email protected]>

* Update website/docs/FAQ.md

Co-authored-by: Chi Wang <[email protected]>

* Update website/docs/FAQ.md

Co-authored-by: Chi Wang <[email protected]>

* Update website/docs/FAQ.md

Co-authored-by: Chi Wang <[email protected]>

* Update FAQ.md

---------

Co-authored-by: Chi Wang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation models Pertains to using alternate, non-GPT, models (e.g., local models, llama, etc.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Why is config list a list?
5 participants