-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FAQ, working with LLM endpoints and explaining why config-list is a list #1451
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice clarifications. Thank you for the contributions!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@maxim-saplin Looks great, nice clarifications given especially with describing how the models are chosen in sequence. I just wrote a few minor comments. When those and the typo's @sonichi mentioned i'm happy to approve 👍
Co-authored-by: Chi Wang <[email protected]>
Co-authored-by: Chi Wang <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1451 +/- ##
=======================================
Coverage 33.19% 33.19%
=======================================
Files 41 41
Lines 4950 4950
Branches 1135 1135
=======================================
Hits 1643 1643
Misses 3177 3177
Partials 130 130
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Co-authored-by: Chi Wang <[email protected]>
Co-authored-by: Chi Wang <[email protected]>
Co-authored-by: Chi Wang <[email protected]>
@AaronWard , @sonichi please check the update |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 💯
…ist (microsoft#1451) * FAQ and notebook extended * Update notebook/oai_openai_utils.ipynb Co-authored-by: Chi Wang <[email protected]> * Update website/docs/FAQ.md Co-authored-by: Chi Wang <[email protected]> * Update website/docs/FAQ.md Co-authored-by: Chi Wang <[email protected]> * Update website/docs/FAQ.md Co-authored-by: Chi Wang <[email protected]> * Update website/docs/FAQ.md Co-authored-by: Chi Wang <[email protected]> * Update FAQ.md --------- Co-authored-by: Chi Wang <[email protected]>
Making the docs clearer about how LLM API endpoint config works.
Related issue number
Closes #749 and #97
Checks