Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed wrong doc link #1449

Merged
merged 3 commits into from
Jan 30, 2024
Merged

fixed wrong doc link #1449

merged 3 commits into from
Jan 30, 2024

Conversation

Yanni8
Copy link
Contributor

@Yanni8 Yanni8 commented Jan 29, 2024

This link points to nothing. I think the right link should point to this

@codecov-commenter
Copy link

codecov-commenter commented Jan 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6cf5bb0) 33.19% compared to head (cd6769c) 33.19%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1449   +/-   ##
=======================================
  Coverage   33.19%   33.19%           
=======================================
  Files          41       41           
  Lines        4950     4950           
  Branches     1135     1135           
=======================================
  Hits         1643     1643           
  Misses       3177     3177           
  Partials      130      130           
Flag Coverage Δ
unittests 33.15% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jackgerrits
Copy link
Member

I just looked on the deployed version of the website and it seems like the link is working (https://microsoft.github.io/autogen/docs/Use-Cases/agent_chat). In what environment did you notice the broken link?

@Yanni8
Copy link
Contributor Author

Yanni8 commented Jan 29, 2024

Hey @jackgerrits

I just looked on the deployed version of the website and it seems like the link is working (https://microsoft.github.io/autogen/docs/Use-Cases/agent_chat). In what environment did you notice the broken link?

Well I think I found the issue. The link on the website redirects me to https://microsoft.github.io/autogen/docs/Use-Cases/agent_chat

Which is greate. But directly requesting the page https://microsoft.github.io/autogen/docs/Use-Cases/agent_chat
redirects me to -> https://microsoft.github.io/autogen/docs/Use-Cases/agent_chat/ (There is an aditional /) which means that the link won't work.

Does this also happen to you?

@jackgerrits
Copy link
Member

Ah thanks for explaining the issue! If you reference the FAQ.md file directly and let docusaurus generate the link then I think things work correctly.

Co-authored-by: Jack Gerrits <[email protected]>
@jackgerrits
Copy link
Member

Thanks for finding this, and pushing through this fix!

@sonichi sonichi enabled auto-merge January 30, 2024 14:49
@sonichi sonichi added this pull request to the merge queue Jan 30, 2024
Merged via the queue into microsoft:main with commit 2467e97 Jan 30, 2024
19 checks passed
whiskyboy pushed a commit to whiskyboy/autogen that referenced this pull request Apr 17, 2024
* fixed wrong doc link

* directly referenced file

Co-authored-by: Jack Gerrits <[email protected]>

* Update website/docs/Use-Cases/agent_chat.md

---------

Co-authored-by: Jack Gerrits <[email protected]>
Co-authored-by: Chi Wang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants