Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: initial Jupyter support for website docs, move config notebook #1448

Merged
merged 11 commits into from
Jan 30, 2024

Conversation

jackgerrits
Copy link
Member

@jackgerrits jackgerrits commented Jan 29, 2024

Adds initial support for rendering notebooks using Quarto. Quarto is a tool for rendering technical documentation. It has specific support for rendering Jupyter notebooks that target the Docsaurus documentation system so it is particularly helpful for us.

Additionally, in this PR I moved the oai_openai_utils notebooks to the main docs section as it is a great notebook for explaining how to setup the LLM config list. I made a small edit to add a TL;DR section at the top of the notebook to get started quickly.

Sidebar with new page:
image

Example of rendered notebook:
image

Related issue number

#1339

@jackgerrits jackgerrits requested review from sonichi and gagb January 29, 2024 13:36
@jackgerrits jackgerrits changed the title docs: jupyter support for website docs, move config docs docs: initial Jupyter support for website docs, move config notebook Jan 29, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jan 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6cf5bb0) 33.19% compared to head (aa2e61c) 33.19%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1448   +/-   ##
=======================================
  Coverage   33.19%   33.19%           
=======================================
  Files          41       41           
  Lines        4950     4950           
  Branches     1135     1135           
=======================================
  Hits         1643     1643           
  Misses       3177     3177           
  Partials      130      130           
Flag Coverage Δ
unittests 33.15% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jackgerrits jackgerrits requested a review from ekzhu January 29, 2024 22:15
Copy link
Contributor

@zwd-ms zwd-ms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@ekzhu ekzhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. One thing I would consider doing is having test in place for the notebooks we have in documentation.

@jackgerrits
Copy link
Member Author

jackgerrits commented Jan 30, 2024

Agreed - @zwd-ms has taken on that task and will be done separately to this PR to ensure it is a holistic solution

@ekzhu
Copy link
Collaborator

ekzhu commented Jan 30, 2024

Agreed - @zwd-ms has taken on that task and will be done separately to this PR to ensure it is a holistic solution.

Thanks @zwd-ms!

@sonichi
Copy link
Contributor

sonichi commented Jan 30, 2024

Shall we move it under "Installation"? I think order wise, it's after installation and before use cases.

@jackgerrits
Copy link
Member Author

Shall we move it under "Installation"? I think order wise, it's after installation and before use cases.

I agree, moved it.

@sonichi sonichi added this pull request to the merge queue Jan 30, 2024
Merged via the queue into microsoft:main with commit 276d5b7 Jan 30, 2024
19 checks passed
whiskyboy pushed a commit to whiskyboy/autogen that referenced this pull request Apr 17, 2024
…icrosoft#1448)

* docs: jupyter support for website docs, move config docs

* update devcontainer dockerfile, fix CI issues

* update bsed on working directory

* update TLDR

* install into temp

* remove unrelated change from diff

* fix spelling issue

* Update sidebars.js
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants