-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve docs/gallery card component #1445
Conversation
@microsoft-github-policy-service agree |
PR looks good, but I think the card looks better with a border on light theme |
Previously border was getting merged with the image, just adding a small padding to image and making the border property true gave this output: Should I push this one? @cheng-tan |
yep, I think this is better for light theme |
Done adding the changes @cheng-tan |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1445 +/- ##
=======================================
Coverage 33.19% 33.19%
=======================================
Files 41 41
Lines 4950 4950
Branches 1135 1135
=======================================
Hits 1643 1643
Misses 3177 3177
Partials 130 130
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Thanks all! |
* Improve docs/gallery card component * added border to gallery card component
Thanks for the merge! |
@jackgerrits sorry to spam unassigned |
* Improve docs/gallery card component * added border to gallery card component
Why are these changes needed?
The gallery features incredibly valuable community contributions, however it doesn't seem like the component in the current docs/gallery card is optimized:
So updated the component to make it look better and more engaging:
Let me know if any changes can be done to this to make it better.
I have continued the design approach by using the antd for typography.
Related issue number
Checks