Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update function call doc with example of not using decorator syntax. #1441

Merged
merged 2 commits into from
Jan 28, 2024

Conversation

ekzhu
Copy link
Collaborator

@ekzhu ekzhu commented Jan 28, 2024

Why are these changes needed?

Update function call doc with example of not using decorator syntax, as many users are not familiar with decorators.

Related issue number

#1213

Checks

@ekzhu ekzhu requested a review from davorrunje January 28, 2024 19:14
@codecov-commenter
Copy link

codecov-commenter commented Jan 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0790da0) 33.19% compared to head (251afc2) 33.19%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1441   +/-   ##
=======================================
  Coverage   33.19%   33.19%           
=======================================
  Files          41       41           
  Lines        4950     4950           
  Branches     1135     1135           
=======================================
  Hits         1643     1643           
  Misses       3177     3177           
  Partials      130      130           
Flag Coverage Δ
unittests 33.15% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@namanbarkiya
Copy link
Contributor

how about adding a notebook example?.. can I add that?

@davorrunje
Copy link
Collaborator

@namanbarkiya there are three notebooks demonstrating how to register functions using decorators (one with currency calculator, one with sync and one with async example). It would be great if you could add an example of using decorators as functions to each of them.

@namanbarkiya
Copy link
Contributor

@davorrunje so I should update the changes in all the 3 files, correct? (append the method in each notebook)

@sonichi sonichi added this pull request to the merge queue Jan 28, 2024
Merged via the queue into microsoft:main with commit 6cf5bb0 Jan 28, 2024
19 checks passed
@ekzhu ekzhu deleted the update-function-call-doc branch January 28, 2024 21:25
@ekzhu
Copy link
Collaborator Author

ekzhu commented Jan 28, 2024

@davorrunje so I should update the changes in all the 3 files, correct? (append the method in each notebook)

yes, you can start a new PR for this

@davorrunje
Copy link
Collaborator

@namanbarkiya actually, I added another utility method and updated everything in #1443. There was another problem I was fixing and just added those few lines while I was at it anyway. Thanx for the help in any case 😃

@namanbarkiya
Copy link
Contributor

No worries! I'll try resolving some other issues, hope I can contribute to this project! 😄

corleroux pushed a commit to corleroux/autogen that referenced this pull request Jan 30, 2024
whiskyboy pushed a commit to whiskyboy/autogen that referenced this pull request Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants