-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update function call doc with example of not using decorator syntax. #1441
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1441 +/- ##
=======================================
Coverage 33.19% 33.19%
=======================================
Files 41 41
Lines 4950 4950
Branches 1135 1135
=======================================
Hits 1643 1643
Misses 3177 3177
Partials 130 130
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
how about adding a notebook example?.. can I add that? |
@namanbarkiya there are three notebooks demonstrating how to register functions using decorators (one with currency calculator, one with sync and one with async example). It would be great if you could add an example of using decorators as functions to each of them. |
@davorrunje so I should update the changes in all the 3 files, correct? (append the method in each notebook) |
yes, you can start a new PR for this |
@namanbarkiya actually, I added another utility method and updated everything in #1443. There was another problem I was fixing and just added those few lines while I was at it anyway. Thanx for the help in any case 😃 |
No worries! I'll try resolving some other issues, hope I can contribute to this project! 😄 |
…icrosoft#1441) * update function call doc to address microsoft#1213 * typo
…icrosoft#1441) * update function call doc to address microsoft#1213 * typo
Why are these changes needed?
Update function call doc with example of not using decorator syntax, as many users are not familiar with decorators.
Related issue number
#1213
Checks