Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(path): Update Installation.md -Update Dockerfile path for Autogen base image build #1425

Merged
merged 2 commits into from
Feb 4, 2024

Conversation

samuelogboye
Copy link
Contributor

This pull request addresses an issue with the Docker build command in the documentation. The original command:

docker build -f .devcontainer/base/Dockerfile -t autogen_base_img https://github.com/microsoft/autogen.git
was updated to:

docker build -f .devcontainer/Dockerfile -t autogen_base_img https://github.com/microsoft/autogen.git
The change eliminates the need to specify "base" in the Dockerfile path when building base images. This adjustment ensures consistency and aligns with the correct path structure.

Reason for the Change:

The previous command had an unnecessary "base" in the Dockerfile path, causing confusion and inconsistency. The updated command simplifies the path, making it more intuitive for users to build base images.

Testing:

The updated command has been tested locally to confirm that it successfully builds the Autogen base image. The build process completes without errors, and the resulting image is as expected.

Error with the former path
image

Checks

@samuelogboye
Copy link
Contributor Author

samuelogboye commented Jan 27, 2024

@sonichi

@victordibia

@sonichi sonichi requested review from gagb and victordibia January 27, 2024 16:39
@samuelogboye
Copy link
Contributor Author

@sonichi
@gagb
@victordibia

kindly check this out.

thanks

@sonichi sonichi mentioned this pull request Feb 4, 2024
3 tasks
@sonichi sonichi requested a review from a team February 4, 2024 19:34
@sonichi
Copy link
Contributor

sonichi commented Feb 4, 2024

@samuelogboye Sorry that I didn't review this earlier. #1533 fixes the same problem, but if you could fix the conflict within the next 24 hours, I would merge your PR first.

@olaoluwasalami
Copy link
Collaborator

olaoluwasalami commented Feb 4, 2024

Hello @samuelogboye Please fix conflict, and I'll approve

@samuelogboye
Copy link
Contributor Author

@samuelogboye please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.

@microsoft-github-policy-service agree [company="{your company}"]

Options:

  • (default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
@microsoft-github-policy-service agree
  • (when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
@microsoft-github-policy-service agree company="Microsoft"

Contributor License Agreement

@microsoft-github-policy-service agree

@codecov-commenter
Copy link

codecov-commenter commented Feb 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3715a74) 34.24% compared to head (3e0297a) 34.24%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1425   +/-   ##
=======================================
  Coverage   34.24%   34.24%           
=======================================
  Files          42       42           
  Lines        5098     5098           
  Branches     1165     1165           
=======================================
  Hits         1746     1746           
  Misses       3209     3209           
  Partials      143      143           
Flag Coverage Δ
unittests 34.24% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@olaoluwasalami olaoluwasalami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sonichi sonichi added this pull request to the merge queue Feb 4, 2024
Merged via the queue into microsoft:main with commit 5b217c9 Feb 4, 2024
19 checks passed
whiskyboy pushed a commit to whiskyboy/autogen that referenced this pull request Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants