-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(path): Update Installation.md -Update Dockerfile path for Autogen base image build #1425
Conversation
kindly check this out. thanks |
@samuelogboye Sorry that I didn't review this earlier. #1533 fixes the same problem, but if you could fix the conflict within the next 24 hours, I would merge your PR first. |
Hello @samuelogboye Please fix conflict, and I'll approve |
@microsoft-github-policy-service agree |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1425 +/- ##
=======================================
Coverage 34.24% 34.24%
=======================================
Files 42 42
Lines 5098 5098
Branches 1165 1165
=======================================
Hits 1746 1746
Misses 3209 3209
Partials 143 143
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
This pull request addresses an issue with the Docker build command in the documentation. The original command:
docker build -f .devcontainer/base/Dockerfile -t autogen_base_img https://github.com/microsoft/autogen.git
was updated to:
docker build -f .devcontainer/Dockerfile -t autogen_base_img https://github.com/microsoft/autogen.git
The change eliminates the need to specify "base" in the Dockerfile path when building base images. This adjustment ensures consistency and aligns with the correct path structure.
Reason for the Change:
The previous command had an unnecessary "base" in the Dockerfile path, causing confusion and inconsistency. The updated command simplifies the path, making it more intuitive for users to build base images.
Testing:
The updated command has been tested locally to confirm that it successfully builds the Autogen base image. The build process completes without errors, and the resulting image is as expected.
Error with the former path
Checks