Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct small typos in system messages #1410

Merged
merged 3 commits into from
Jan 27, 2024
Merged

Conversation

pbadeer
Copy link
Contributor

@pbadeer pbadeer commented Jan 26, 2024

Why are these changes needed?

Just correcting misspelling of the word "coordinator" in a number of default system messages.

Related issue number

Checks

@pbadeer
Copy link
Contributor Author

pbadeer commented Jan 26, 2024

@microsoft-github-policy-service agree

Copy link
Collaborator

@BeibinLi BeibinLi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonichi sonichi requested a review from victordibia January 26, 2024 16:59
Copy link
Collaborator

@victordibia victordibia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These look good to me. Thanks.

@pbadeer , thanks for the updates.
In the future, for autogenstudio updates, it would be great to follow the autogenstudio contribution guide

The main change is that autogenstudio is being heavily developed on the autogenstudio branch. It would be helpful to merge into that branch to ensure consistency.

@jackgerrits @BeibinLi

@pbadeer
Copy link
Contributor Author

pbadeer commented Jan 26, 2024

Will use that branch next time, sorry for the mistake.

@codecov-commenter
Copy link

codecov-commenter commented Jan 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (fd0094c) 32.48% compared to head (c497fba) 32.48%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1410   +/-   ##
=======================================
  Coverage   32.48%   32.48%           
=======================================
  Files          41       41           
  Lines        4907     4907           
  Branches     1120     1120           
=======================================
  Hits         1594     1594           
  Misses       3187     3187           
  Partials      126      126           
Flag Coverage Δ
unittests 32.44% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sonichi
Copy link
Contributor

sonichi commented Jan 26, 2024

Could you fix the code format error? You can use pre-commit to help.

@sonichi sonichi enabled auto-merge January 27, 2024 18:58
@sonichi sonichi added this pull request to the merge queue Jan 27, 2024
Merged via the queue into microsoft:main with commit 26a0694 Jan 27, 2024
19 checks passed
corleroux pushed a commit to corleroux/autogen that referenced this pull request Jan 30, 2024
* Update utils.ts - fix small typo in default system message

* Fix typos in system messages

---------

Co-authored-by: Preston Badeer <[email protected]>
Co-authored-by: Chi Wang <[email protected]>
@pbadeer pbadeer deleted the patch-1 branch February 9, 2024 03:34
whiskyboy pushed a commit to whiskyboy/autogen that referenced this pull request Apr 17, 2024
* Update utils.ts - fix small typo in default system message

* Fix typos in system messages

---------

Co-authored-by: Preston Badeer <[email protected]>
Co-authored-by: Chi Wang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants