-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix image print for auto feedback from code notebook #1389
Fix image print for auto feedback from code notebook #1389
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1389 +/- ##
==========================================
+ Coverage 33.08% 40.86% +7.78%
==========================================
Files 42 42
Lines 5048 5048
Branches 1156 1223 +67
==========================================
+ Hits 1670 2063 +393
+ Misses 3250 2795 -455
- Partials 128 190 +62
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Let me just understand the problem before I get on my laptop and run it myself, the issue was that the image was not displayed in notebook? If so, wouldn't it be better to check if the file exists, load it from file and then display it? That way we know what is in the file is actually what we are looking into. Not saying the PR is wrong, but this solution would be more robust. |
The image does not display in GitHub Codespace. You just ask explicitly to display it and now it works. |
LGTM 👍 |
* Add .notebook folder to gitignore * Add the import of display (IPython) and call it to display the chart * Remove the update of .gitignore
Why are these changes needed?
It solves the display of the chart in notebook/agentchat_auto_feedback_from_code_execution.ipynb. I also added .notebook in the
.gitignore
to be able to have a folder to update the notebooks for testing without risking to commit them.Checks