Skip to content

Change last_n_messages to default to 'auto' #1356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jan 23, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions autogen/agentchat/conversable_agent.py
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@ def __init__(
If False, the code will be executed in the current environment.
We strongly recommend using docker for code execution.
- timeout (Optional, int): The maximum execution time in seconds.
- last_n_messages (Experimental, Optional, int or str): The number of messages to look back for code execution. Default to 1. If set to 'auto', it will scan backwards through all messages arriving since the agent last spoke (typically this is the last time execution was attempted).
- last_n_messages (Experimental, Optional, int or str): The number of messages to look back for code execution. If set to 'auto', it will scan backwards through all messages arriving since the agent last spoke, which is typically the last time execution was attempted. (Default: auto)
llm_config (dict or False): llm inference configuration.
Please refer to [OpenAIWrapper.create](/docs/reference/oai/client#create)
for available options.
Expand Down Expand Up @@ -839,7 +839,10 @@ def generate_code_execution_reply(
return False, None
if messages is None:
messages = self._oai_messages[sender]
last_n_messages = code_execution_config.pop("last_n_messages", 1)
last_n_messages = code_execution_config.pop("last_n_messages", "auto")

if not (isinstance(last_n_messages, (int, float)) and last_n_messages >= 0) and last_n_messages != "auto":
raise ValueError("last_n_messages must be either a non-negative integer, or the string 'auto'.")

messages_to_scan = last_n_messages
if last_n_messages == "auto":
Expand Down
13 changes: 11 additions & 2 deletions test/agentchat/test_conversable_agent.py
Original file line number Diff line number Diff line change
Expand Up @@ -323,6 +323,15 @@ def test_generate_code_execution_reply():
)
assert agent._code_execution_config["last_n_messages"] == "auto"

# scenario 8: if last_n_messages is misconfigures, we expect to see an error
with pytest.raises(ValueError):
agent._code_execution_config = {"last_n_messages": -1, "use_docker": False}
agent.generate_code_execution_reply([code_message])

with pytest.raises(ValueError):
agent._code_execution_config = {"last_n_messages": "hello world", "use_docker": False}
agent.generate_code_execution_reply([code_message])


def test_max_consecutive_auto_reply():
agent = ConversableAgent("a0", max_consecutive_auto_reply=2, llm_config=False, human_input_mode="NEVER")
Expand Down Expand Up @@ -987,6 +996,6 @@ def test_no_llm_config():
# test_trigger()
# test_context()
# test_max_consecutive_auto_reply()
# test_generate_code_execution_reply()
test_generate_code_execution_reply()
# test_conversable_agent()
test_no_llm_config()
# test_no_llm_config()