Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Python 3.12 #1317

Merged
merged 11 commits into from
Jan 18, 2024
Merged

Support for Python 3.12 #1317

merged 11 commits into from
Jan 18, 2024

Conversation

ekzhu
Copy link
Collaborator

@ekzhu ekzhu commented Jan 18, 2024

Why are these changes needed?

Support for Python 3.12.

Related issue number

#101 aiohttp now supports 3.12.

Checks

@codecov-commenter
Copy link

codecov-commenter commented Jan 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (73c7522) 32.06% compared to head (2e32a8c) 41.88%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1317      +/-   ##
==========================================
+ Coverage   32.06%   41.88%   +9.81%     
==========================================
  Files          33       33              
  Lines        4422     4422              
  Branches     1034     1089      +55     
==========================================
+ Hits         1418     1852     +434     
+ Misses       2887     2421     -466     
- Partials      117      149      +32     
Flag Coverage Δ
unittests 41.81% <ø> (+9.79%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@sonichi sonichi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test passed. We can change the pull_request_target back. I suggest changing the banner in README.md and remove unnecessary newly added imports. Then I'll approve.

@ekzhu
Copy link
Collaborator Author

ekzhu commented Jan 18, 2024

@sonichi Done.

@sonichi sonichi added this pull request to the merge queue Jan 18, 2024
Merged via the queue into main with commit 22e36cb Jan 18, 2024
91 of 99 checks passed
@sonichi sonichi deleted the 3.12 branch January 18, 2024 08:28
whiskyboy pushed a commit to whiskyboy/autogen that referenced this pull request Apr 17, 2024
* support for Python 3.12

* add python 3.12 to workflows

* version string fix

* retrieval chat

* teachability

* workflow

* redistribute notebook tests

* fix incorrect notebook introduction

* update banner; remove unused imports; update openai workflow

---------

Co-authored-by: Chi Wang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants