-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for Python 3.12 #1317
Support for Python 3.12 #1317
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1317 +/- ##
==========================================
+ Coverage 32.06% 41.88% +9.81%
==========================================
Files 33 33
Lines 4422 4422
Branches 1034 1089 +55
==========================================
+ Hits 1418 1852 +434
+ Misses 2887 2421 -466
- Partials 117 149 +32
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The test passed. We can change the pull_request_target back. I suggest changing the banner in README.md and remove unnecessary newly added imports. Then I'll approve.
@sonichi Done. |
* support for Python 3.12 * add python 3.12 to workflows * version string fix * retrieval chat * teachability * workflow * redistribute notebook tests * fix incorrect notebook introduction * update banner; remove unused imports; update openai workflow --------- Co-authored-by: Chi Wang <[email protected]>
Why are these changes needed?
Support for Python 3.12.
Related issue number
#101 aiohttp now supports 3.12.
Checks