Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More documentation for Cache. Updated FAQ to include database Locked error #1291

Merged
merged 7 commits into from
Jan 20, 2024

Conversation

balakreshnan
Copy link
Collaborator

@balakreshnan balakreshnan commented Jan 16, 2024

Database Locked error in Azure Machine Learning compute instance

Why are these changes needed?

Related issue number

Checks

Database Locked error in Azure Machine Learning compute instance
@codecov-commenter
Copy link

codecov-commenter commented Jan 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ee6ad8d) 34.56% compared to head (b3efdae) 44.08%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1291      +/-   ##
==========================================
+ Coverage   34.56%   44.08%   +9.51%     
==========================================
  Files          38       38              
  Lines        4586     4587       +1     
  Branches     1060     1123      +63     
==========================================
+ Hits         1585     2022     +437     
+ Misses       2875     2407     -468     
- Partials      126      158      +32     
Flag Coverage Δ
unittests 44.01% <100.00%> (+9.49%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ekzhu
Copy link
Collaborator

ekzhu commented Jan 16, 2024

raise awareness to @sonichi regarding cache that relies on local filesystem access

Copy link
Contributor

@sonichi sonichi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ekzhu @vijaykramesh Do we need to update this part after #1222 is merged?

website/docs/FAQ.md Outdated Show resolved Hide resolved
website/docs/FAQ.md Outdated Show resolved Hide resolved
@ekzhu
Copy link
Collaborator

ekzhu commented Jan 17, 2024

The doc needs to be update again once #1222 is merged. Let's wait for that one to merge first.

@sonichi sonichi added the documentation Improvements or additions to documentation label Jan 18, 2024
website/docs/FAQ.md Outdated Show resolved Hide resolved
@ekzhu ekzhu changed the title Database Locked error in Azure Machine Learning compute instance More documentation for Cache. Updated FAQ to include database Locked error Jan 20, 2024
@ekzhu
Copy link
Collaborator

ekzhu commented Jan 20, 2024

I added more documentation for Cache, added Cache to top-level module so we can do from autogen import Cache

@sonichi sonichi added this pull request to the merge queue Jan 20, 2024
Merged via the queue into microsoft:main with commit ca56782 Jan 20, 2024
88 of 97 checks passed
corleroux pushed a commit to corleroux/autogen that referenced this pull request Jan 30, 2024
…error (microsoft#1291)

* Update FAQ.md

Database Locked error in Azure Machine Learning compute instance

* Update website/docs/FAQ.md

Co-authored-by: Chi Wang <[email protected]>

* Update website/docs/FAQ.md

Co-authored-by: Chi Wang <[email protected]>

* update doc; add module import for Cache

* update doc

* nit

---------

Co-authored-by: Eric Zhu <[email protected]>
Co-authored-by: Chi Wang <[email protected]>
whiskyboy pushed a commit to whiskyboy/autogen that referenced this pull request Apr 17, 2024
…error (microsoft#1291)

* Update FAQ.md

Database Locked error in Azure Machine Learning compute instance

* Update website/docs/FAQ.md

Co-authored-by: Chi Wang <[email protected]>

* Update website/docs/FAQ.md

Co-authored-by: Chi Wang <[email protected]>

* update doc; add module import for Cache

* update doc

* nit

---------

Co-authored-by: Eric Zhu <[email protected]>
Co-authored-by: Chi Wang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants