add workdir in test #1274
Merged
add workdir in test #1274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1274 +/- ##
==========================================
+ Coverage 32.08% 41.66% +9.57%
==========================================
Files 32 32
Lines 4394 4416 +22
Branches 1025 1099 +74
==========================================
+ Hits 1410 1840 +430
+ Misses 2867 2401 -466
- Partials 117 175 +58
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
joshkyh
pushed a commit
that referenced
this pull request
Jan 17, 2024
* add workdir in test * catch filenotfound * modify print msg
whiskyboy
pushed a commit
to whiskyboy/autogen
that referenced
this pull request
Apr 17, 2024
* add workdir in test * catch filenotfound * modify print msg
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Without work_dir, one test can run into permission error. For example, https://github.com/microsoft/autogen/actions/runs/7535775093/job/20512243608?pr=1269
Related issue number
Checks