Replaced asyncio.coroutines.iscoroutinefunction with inspect.iscoroutinefunction

[davorrunje]

Why are these changes needed?

In several places asyncio.coroutines.iscoroutinefunction was used instead of inspect.iscoroutinefunction.

Both asyncio.coroutines.iscoroutinefunction and inspect.iscoroutinefunction are used to check if a function is a coroutine function. However, they differ in the types of functions they consider to be coroutine functions.

• inspect.iscoroutinefunction considers a function to be a coroutine function if it is either:

  • A function decorated with async def
  • A function decorated with @asyncio.coroutine

• asyncio.coroutines.iscoroutinefunction only considers a function to be a coroutine function if it is decorated with @asyncio.coroutine. It does not consider functions decorated with async def to be coroutine functions.

See e.g. https://stackoverflow.com/questions/59343239/asyncio-iscoroutinefunction-returns-false-for-asynchronous-generator

Related issue number

Closes #1260

Checks

• I've included any doc changes needed for https://microsoft.github.io/autogen/. See https://microsoft.github.io/autogen/docs/Contribute#documentation to build and test documentation locally.
• I've added tests (if relevant) corresponding to the changes introduced in this PR.
• I've made sure all auto checks have passed.

[codecov-commenter]

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (135bca4) 32.11% compared to head (4c0953b) 51.09%.

Files	Patch %	Lines
autogen/agentchat/conversable_agent.py	62.50%	1 Missing and 2 partials ⚠️
autogen/agentchat/contrib/compressible_agent.py	50.00%	1 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##             main    #1267       +/-   ##
===========================================
+ Coverage   32.11%   51.09%   +18.98%     
===========================================
  Files          32       32               
  Lines        4391     4392        +1     
  Branches     1024     1079       +55     
===========================================
+ Hits         1410     2244      +834     
+ Misses       2865     1944      -921     
- Partials      116      204       +88     

Flag	Coverage Δ
unittests	51.02% <60.00%> (+18.95%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[ekzhu]

@qingyun-wu

[qingyun-wu]

LGTM! Thanks!