remove name from tool response #1263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1263 +/- ##
===========================================
+ Coverage 32.10% 51.20% +19.10%
===========================================
Files 32 32
Lines 4392 4394 +2
Branches 1024 1080 +56
===========================================
+ Hits 1410 2250 +840
+ Misses 2866 1941 -925
- Partials 116 203 +87
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Thanks. Could you modify the test to address the test failures? |
davorrunje
approved these changes
Jan 15, 2024
|
@yenif the openai test is failing: https://github.com/microsoft/autogen/actions/runs/7532202265/job/20511225188?pr=1263#step:7:1189 Could you take a look this? Thank you! |
joshkyh
pushed a commit
that referenced
this pull request
Jan 17, 2024
* remove name from tool response * fix tool response tests * fix output string
whiskyboy
pushed a commit
to whiskyboy/autogen
that referenced
this pull request
Apr 17, 2024
* remove name from tool response * fix tool response tests * fix output string
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
#1255
Related issue number
Closes #1255
Checks