Docker Documentation #1251
Merged
Docker Documentation #1251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
January 13, 2024 22:10
…tallation.md file and a start.sh file for the Dockerfile.dev to start the document server. Not ready for pull request.
|
@microsoft-github-policy-service agree |
sonichi
requested review from
qingyun-wu,
maxim-saplin,
yuandong-tian and
olgavrou
sonichi
reviewed
Jan 14, 2024
|
Hey all, Ill close and re-submit with that edit removed. my apologies |
|
closing to address issues with websites/sidebars.js |
removed un-related change from website/sidebars.js
|
sorry about that, I have fixed the issues with the website/sidebards.js file. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1251 +/- ##
=======================================
Coverage 32.11% 32.11%
=======================================
Files 32 32
Lines 4391 4391
Branches 1024 1024
=======================================
Hits 1410 1410
Misses 2865 2865
Partials 116 116
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Could you fix the conflicts? Thank you! |
qingyun-wu
reviewed
Jan 14, 2024
added the missing sections back. However, do we still want the docker section under the Optional Dependencies? That looks like it would go better in the Dockerfiles.md file.
Added mount your code back and added mount your directory for better clarity.
r3d91ll
commented
Jan 14, 2024
Lint cleanup
removed the relative path to samples/dockers/Dockerfiles.md with a proper URL to where it will exist
qingyun-wu
reviewed
Jan 15, 2024
qingyun-wu
approved these changes
Jan 15, 2024
joshkyh
pushed a commit
that referenced
this pull request
Jan 17, 2024
* Updates to the Dockerfiles making them more secure. update to the installation.md file and a start.sh file for the Dockerfile.dev to start the document server. Not ready for pull request. * updates to the docker documentation * clean up before commit * added docker instructions on how to test documentation prior to commit. * fixed the title heading in the installation.md * removed alternate yarn install from Dockerfile.dev * Update sidebars.js removed un-related change from website/sidebars.js * cleaned up the lint errors from the pre-commit-check. * removed bad edit from sidebars.js * fixing git conflict with sidebars.js file * Update Installation.md added the missing sections back. However, do we still want the docker section under the Optional Dependencies? That looks like it would go better in the Dockerfiles.md file. * Update Installation.md Added mount your code back and added mount your directory for better clarity. * Update Installation.md Lint cleanup * Update Installation.md removed the relative path to samples/dockers/Dockerfiles.md with a proper URL to where it will exist * fixed bad link to Dockerfiles.md * Fix trailing whitespace and formatting issues * Update link to Dockerfiles.md * somtimes its really hard to find that lost i. * trailing whitespace and EOF issues resolved * fixed broken link * trailing space an broken link * removed broken links. will update one merged. * fixed glaring error about building an image from a particular branch Contribute.md * removed tic mark typo from contribute.md --------- Co-authored-by: Todd W Bucy <todd.bucy@rackspace>
whiskyboy
pushed a commit
to whiskyboy/autogen
that referenced
this pull request
Apr 17, 2024
* Updates to the Dockerfiles making them more secure. update to the installation.md file and a start.sh file for the Dockerfile.dev to start the document server. Not ready for pull request. * updates to the docker documentation * clean up before commit * added docker instructions on how to test documentation prior to commit. * fixed the title heading in the installation.md * removed alternate yarn install from Dockerfile.dev * Update sidebars.js removed un-related change from website/sidebars.js * cleaned up the lint errors from the pre-commit-check. * removed bad edit from sidebars.js * fixing git conflict with sidebars.js file * Update Installation.md added the missing sections back. However, do we still want the docker section under the Optional Dependencies? That looks like it would go better in the Dockerfiles.md file. * Update Installation.md Added mount your code back and added mount your directory for better clarity. * Update Installation.md Lint cleanup * Update Installation.md removed the relative path to samples/dockers/Dockerfiles.md with a proper URL to where it will exist * fixed bad link to Dockerfiles.md * Fix trailing whitespace and formatting issues * Update link to Dockerfiles.md * somtimes its really hard to find that lost i. * trailing whitespace and EOF issues resolved * fixed broken link * trailing space an broken link * removed broken links. will update one merged. * fixed glaring error about building an image from a particular branch Contribute.md * removed tic mark typo from contribute.md --------- Co-authored-by: Todd W Bucy <todd.bucy@rackspace>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey All,
I have updated the Docker instructions for the website. The following website documents have been updated:
Installation.md - changes here focus how to use the the Dockerfile.base and Dockerfile.full
Contribute.md - This section focuses on how to use Dockerfile.dev to contribute to the project.
Additionally, changes were made to the Dockerfile.base, Dockerfile.full, and Dockerfile.dev files in autogen/samples/docker/ and I also created a Dockerfiles.md, which discusses how to use it for Development and how to adjust the Dockerfile to fit particular Dev environments.
Why are these changes needed?
Related issue number
#1103 #1147 #1111
Checks