Allow initiate_chat without passing message #1244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1244 +/- ##
===========================================
+ Coverage 33.34% 66.53% +33.19%
===========================================
Files 33 33
Lines 4456 4462 +6
Branches 1041 1098 +57
===========================================
+ Hits 1486 2969 +1483
+ Misses 2848 1182 -1666
- Partials 122 311 +189
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
sonichi
requested review from
ekzhu,
AaronWard,
rickyloynd-microsoft and
danyrouh
|
If folks are OK with this change, a test should be added to cover the added case. |
rickyloynd-microsoft
approved these changes
Jan 14, 2024
|
@bitnom could you add a test to cover the new line added? |
ekzhu
requested changes
Jan 15, 2024
it is committed |
ekzhu
reviewed
Jan 15, 2024
should be good now |
ekzhu
approved these changes
Jan 16, 2024
sonichi
reviewed
Jan 19, 2024
corleroux
pushed a commit
to corleroux/autogen
that referenced
this pull request
Jan 30, 2024
* allow initiate_chat without passing message * test human input * assert called * Add missing method a_generate_init_message * fix tests * add back skipif * Update test/agentchat/test_async_get_human_input.py --------- Co-authored-by: Chi Wang <[email protected]>
whiskyboy
pushed a commit
to whiskyboy/autogen
that referenced
this pull request
Apr 17, 2024
* allow initiate_chat without passing message * test human input * assert called * Add missing method a_generate_init_message * fix tests * add back skipif * Update test/agentchat/test_async_get_human_input.py --------- Co-authored-by: Chi Wang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A very minor change to call
self.get_human_input()ifmessageis not supplied.