Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug in async group chat with func/tool call #1243

Merged
merged 5 commits into from
Jan 14, 2024
Merged

Fix bug in async group chat with func/tool call #1243

merged 5 commits into from
Jan 14, 2024

Conversation

sonichi
Copy link
Contributor

@sonichi sonichi commented Jan 14, 2024

Why are these changes needed?

The async group chat doesn't preprocess tool call message the same way as the sync. This PR fixes that by extracting the common code out. This PR also adds tests for the case where there are >2 agents in the group chat, with 1 agent for tool proposer, 1 agent for execution, and 1 agent not knowing the tool definition.

This PR also fixes a bug in test code introduced in #1227 which will fail the openai test and block other PRs.

Related issue number

Close #1238

Checks

@codecov-commenter
Copy link

codecov-commenter commented Jan 14, 2024

Codecov Report

Attention: 9 lines in your changes are missing coverage. Please review.

Comparison is base (42674c5) 31.45% compared to head (db2d953) 41.46%.

Files Patch % Lines
autogen/agentchat/groupchat.py 66.66% 7 Missing and 2 partials ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1243       +/-   ##
===========================================
+ Coverage   31.45%   41.46%   +10.00%     
===========================================
  Files          32       32               
  Lines        4393     4389        -4     
  Branches     1026     1079       +53     
===========================================
+ Hits         1382     1820      +438     
+ Misses       2902     2427      -475     
- Partials      109      142       +33     
Flag Coverage Δ
unittests 41.39% <66.66%> (+9.98%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sonichi sonichi added this pull request to the merge queue Jan 14, 2024
Merged via the queue into main with commit f9c16d2 Jan 14, 2024
78 of 87 checks passed
@sonichi sonichi deleted the i1238 branch January 14, 2024 18:28
joshkyh pushed a commit that referenced this pull request Jan 17, 2024
* test func/tool call in group chat w/ >2 agents

* filter_dict -> exclude

* modify comment

* add last message to groupchat

* typecheck allow_repeat_speaker
whiskyboy pushed a commit to whiskyboy/autogen that referenced this pull request Apr 17, 2024
* test func/tool call in group chat w/ >2 agents

* filter_dict -> exclude

* modify comment

* add last message to groupchat

* typecheck allow_repeat_speaker
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Tool call in group chat
6 participants