-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix bug in async group chat with func/tool call #1243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1243 +/- ##
===========================================
+ Coverage 31.45% 41.46% +10.00%
===========================================
Files 32 32
Lines 4393 4389 -4
Branches 1026 1079 +53
===========================================
+ Hits 1382 1820 +438
+ Misses 2902 2427 -475
- Partials 109 142 +33
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
sonichi
requested review from
afourney,
yiranwu0,
yenif,
davorrunje,
ekzhu and
yoadsn
January 14, 2024 06:41
This was referenced Jan 14, 2024
ekzhu
approved these changes
Jan 14, 2024
maxim-saplin
approved these changes
Jan 14, 2024
davorrunje
reviewed
Jan 14, 2024
3 tasks
joshkyh
pushed a commit
that referenced
this pull request
Jan 17, 2024
* test func/tool call in group chat w/ >2 agents * filter_dict -> exclude * modify comment * add last message to groupchat * typecheck allow_repeat_speaker
whiskyboy
pushed a commit
to whiskyboy/autogen
that referenced
this pull request
Apr 17, 2024
* test func/tool call in group chat w/ >2 agents * filter_dict -> exclude * modify comment * add last message to groupchat * typecheck allow_repeat_speaker
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
The async group chat doesn't preprocess tool call message the same way as the sync. This PR fixes that by extracting the common code out. This PR also adds tests for the case where there are >2 agents in the group chat, with 1 agent for tool proposer, 1 agent for execution, and 1 agent not knowing the tool definition.
This PR also fixes a bug in test code introduced in #1227 which will fail the openai test and block other PRs.
Related issue number
Close #1238
Checks