Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds TinyRA as a sample app #1221

Closed
wants to merge 167 commits into from
Closed

Adds TinyRA as a sample app #1221

wants to merge 167 commits into from

Conversation

gagb
Copy link
Collaborator

@gagb gagb commented Jan 12, 2024

This pull request mainly focuses on the setup and development of a new application called TinyRA. The changes include the creation of a Docker environment for the application, the addition of necessary dependencies, and the creation of essential files and directories for the application.

Docker environment setup:

  • .devcontainer/tinyRA/Dockerfile: Created a Dockerfile for setting up the Python development environment. This includes the installation of essential packages and tools like npm, tmux, and yarn.
  • .devcontainer/tinyRA/devcontainer.json: Created a devcontainer.json file that specifies the Dockerfile to use, the command to update the content, and the necessary VS Code extensions for the development environment.

Application setup:

Application development:

  • samples/apps/tinyRA/tinyra/tui.css: Created a CSS file for styling the terminal user interface of the application.
  • samples/apps/tinyRA/tinyra/version.py: Defined the version of the tinyra module.
  • samples/apps/tinyRA/tinyra/tui.py: Defines the main logic of the app: It implements three screen, the main screen that displays the chat and then also:
    • App: The main chat display is a container that displays the chat history, arranged in a chronological order, fetched from a database. It includes a reactive markdown widget for displaying assistant messages and a regular markdown widget for displaying user messages, both of which are updated dynamically as new messages are added (or edited) to the chat.
    • QuitScreen: This is a modal screen that provides the user with an option to quit the application. It may include a confirmation dialog and buttons for confirming or canceling the action.
    • SettingsScreen: This is a modal screen that allows the user to view and modify their user settings, tool settings, and history. Major components could include:
      • UserSettings: Allows users to modify personal data, account settings, and security settings.
      • ToolSettings: Allows users to configure the tools they use within the application.
      • History: Displays the user's activity history on the application.

Limitations

Current app encounters some bugs because of #1824.

Tasks Based on Review Feedback

Refactor will be in the following branch: TODO

  • Type more code
  • Use makedirs correctly
  • Cleanup constructor by removing code that may throw errors
  • Make types and return types consistent esp when handling errors
  • Understand "look before leap"
  • Use named tuple for reactive
  • Do not nest scrollable containers

@codecov-commenter
Copy link

codecov-commenter commented Jan 16, 2024

Codecov Report

Attention: Patch coverage is 84.90566% with 8 lines in your changes are missing coverage. Please review.

Project coverage is 49.66%. Comparing base (7a685b5) to head (4069641).
Report is 16 commits behind head on main.

❗ Current head 4069641 differs from pull request most recent head a7ddaaa. Consider uploading reports for the commit a7ddaaa to get more accurate results

Files Patch % Lines
autogen/coding/func_with_reqs.py 84.31% 5 Missing and 3 partials ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1221       +/-   ##
===========================================
+ Coverage   37.55%   49.66%   +12.10%     
===========================================
  Files          77       77               
  Lines        7719     7780       +61     
  Branches     1657     1803      +146     
===========================================
+ Hits         2899     3864      +965     
+ Misses       4574     3591      -983     
- Partials      246      325       +79     
Flag Coverage Δ
unittest 14.37% <43.39%> (?)
unittests 48.59% <84.90%> (+11.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gagb gagb removed the ui/deploy label Jan 17, 2024
@gagb gagb requested a review from olgavrou January 17, 2024 21:33
@afourney
Copy link
Member

Love to see the TUI in the sample apps.

One natural question is if it will support the same "skills" format at AutoGenStudio -- it would be great if it does.

Copy link

gitguardian bot commented Jul 20, 2024

⚠️ GitGuardian has uncovered 4 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

Since your pull request originates from a forked repository, GitGuardian is not able to associate the secrets uncovered with secret incidents on your GitGuardian dashboard.
Skipping this check run and merging your pull request will create secret incidents on your GitGuardian dashboard.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
10404662 Triggered Generic CLI Secret d7ea410 .github/workflows/dotnet-release.yml View secret
10404662 Triggered Generic CLI Secret 9a484d8 .github/workflows/dotnet-build.yml View secret
10404695 Triggered Generic High Entropy Secret abad9ff test/oai/test_utils.py View secret
10404695 Triggered Generic High Entropy Secret c7bb588 test/oai/test_utils.py View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@gagb gagb marked this pull request as draft September 9, 2024 05:43
@ekzhu ekzhu changed the base branch from main to 0.2 October 2, 2024 18:30
@jackgerrits jackgerrits added the 0.2 Issues which are related to the pre 0.4 codebase label Oct 4, 2024
@rysweet
Copy link
Collaborator

rysweet commented Oct 10, 2024

This PR is against AutoGen 0.2. AutoGen 0.2 has been moved to the 0.2 branch. Please rebase your PR on the 0.2 branch or update it to work with the new AutoGen 0.4 that is now in main.

@rysweet rysweet added the awaiting-op-response Issue or pr has been triaged or responded to and is now awaiting a reply from the original poster label Oct 10, 2024
@rysweet
Copy link
Collaborator

rysweet commented Oct 11, 2024

@gagb do we still need this one?

@rysweet
Copy link
Collaborator

rysweet commented Oct 18, 2024

closing as stale. please reopen if you would like to update

@rysweet rysweet closed this Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0.2 Issues which are related to the pre 0.4 codebase awaiting-op-response Issue or pr has been triaged or responded to and is now awaiting a reply from the original poster
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants