-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add documentation and raise exception when registering async reply function in sync chat #1208
Merged
sonichi
merged 8 commits into
main
from
1195-feature-request-add-documentation-for-registering-async-reply-function-in-sync-chat
Jan 13, 2024
Merged
Add documentation and raise exception when registering async reply function in sync chat #1208
sonichi
merged 8 commits into
main
from
1195-feature-request-add-documentation-for-registering-async-reply-function-in-sync-chat
Jan 13, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1208 +/- ##
===========================================
+ Coverage 30.63% 50.30% +19.67%
===========================================
Files 32 32
Lines 4365 4381 +16
Branches 1015 1077 +62
===========================================
+ Hits 1337 2204 +867
+ Misses 2932 1964 -968
- Partials 96 213 +117
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Co-authored-by: Chi Wang <[email protected]>
sonichi
deleted the
1195-feature-request-add-documentation-for-registering-async-reply-function-in-sync-chat
branch
January 13, 2024 07:39
joshkyh
pushed a commit
that referenced
this pull request
Jan 17, 2024
…nction in sync chat (#1208) * documentation update and added tests for register_reply function * added raising an exception on an async reply function in sync chat * big fixing * test expanded * Update autogen/agentchat/conversable_agent.py Co-authored-by: Chi Wang <[email protected]> * Update autogen/agentchat/conversable_agent.py Co-authored-by: Chi Wang <[email protected]> * refactorization --------- Co-authored-by: Chi Wang <[email protected]>
whiskyboy
pushed a commit
to whiskyboy/autogen
that referenced
this pull request
Apr 17, 2024
…nction in sync chat (microsoft#1208) * documentation update and added tests for register_reply function * added raising an exception on an async reply function in sync chat * big fixing * test expanded * Update autogen/agentchat/conversable_agent.py Co-authored-by: Chi Wang <[email protected]> * Update autogen/agentchat/conversable_agent.py Co-authored-by: Chi Wang <[email protected]> * refactorization --------- Co-authored-by: Chi Wang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Current state:
sync
reply function and initiate anasync
chat, the reply function will be triggered.async
reply function and initiate async
chat, the reply function will not be triggered.sync
or bothasync
, then the reply function would be triggered.Proposed change:
async
reply function and initiate async
chat, aRunTime exception
will be raised unless we explicitly specify that the function should be ignored in sync chat.Related issue number
Closes #1195
Checks