Fix registration of async functions #1201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1201 +/- ##
===========================================
+ Coverage 30.51% 61.28% +30.76%
===========================================
Files 32 32
Lines 4355 4365 +10
Branches 1012 1070 +58
===========================================
+ Hits 1329 2675 +1346
+ Misses 2931 1397 -1534
- Partials 95 293 +198
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
davorrunje
commented
Jan 10, 2024
yenif
approved these changes
Jan 10, 2024
sonichi
reviewed
Jan 11, 2024
joshkyh
pushed a commit
that referenced
this pull request
Jan 17, 2024
* bug fix for async functions * Update test_conversable_agent.py Co-authored-by: Chi Wang <[email protected]> * Update test/agentchat/test_conversable_agent.py Co-authored-by: Chi Wang <[email protected]> * commented out cell in a notebook until issue #1205 is not fixed --------- Co-authored-by: Chi Wang <[email protected]>
whiskyboy
pushed a commit
to whiskyboy/autogen
that referenced
this pull request
Apr 17, 2024
* bug fix for async functions * Update test_conversable_agent.py Co-authored-by: Chi Wang <[email protected]> * Update test/agentchat/test_conversable_agent.py Co-authored-by: Chi Wang <[email protected]> * commented out cell in a notebook until issue microsoft#1205 is not fixed --------- Co-authored-by: Chi Wang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Fixes registration of
asyncfunctions.Related issue number
Closes #1191
Checks