-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
check tool_returns #1187
check tool_returns #1187
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1187 +/- ##
==========================================
+ Coverage 30.41% 39.50% +9.09%
==========================================
Files 32 32
Lines 4301 4303 +2
Branches 993 1045 +52
==========================================
+ Hits 1308 1700 +392
+ Misses 2899 2477 -422
- Partials 94 126 +32
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah, yup thats it
* check tool_returns * bump version to 0.2.6
Why are these changes needed?
Need to check whether tool_returns is empty before returning.
TODO in a separate PR: add a test to cover human_input_mode="ALWAYS"
Related issue number
Close #1174
Checks