Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade docusaurus #1101

Merged
merged 38 commits into from
Jan 13, 2024
Merged

Upgrade docusaurus #1101

merged 38 commits into from
Jan 13, 2024

Conversation

olaoluwasalami
Copy link
Collaborator

@olaoluwasalami olaoluwasalami commented Dec 30, 2023

Why are these changes needed?

Upgrade docusaurus to the latest version

Upgrade docusaurus to v3

Related issue number

#1041

Checks

@codecov-commenter
Copy link

codecov-commenter commented Dec 30, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2e519b0) 30.63% compared to head (651777b) 40.54%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1101      +/-   ##
==========================================
+ Coverage   30.63%   40.54%   +9.91%     
==========================================
  Files          32       32              
  Lines        4365     4365              
  Branches     1015     1070      +55     
==========================================
+ Hits         1337     1770     +433     
+ Misses       2932     2467     -465     
- Partials       96      128      +32     
Flag Coverage Δ
unittests 40.48% <ø> (+9.89%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@olaoluwasalami olaoluwasalami changed the title Upgrade docusarus Upgrade docusaurus Dec 30, 2023
@olaoluwasalami olaoluwasalami marked this pull request as ready for review January 1, 2024 18:01
@sonichi sonichi requested a review from skzhang1 January 1, 2024 22:16
@sonichi sonichi added the documentation Improvements or additions to documentation label Jan 1, 2024
@sonichi
Copy link
Contributor

sonichi commented Jan 1, 2024

The workflow fails.

@qingyun-wu
Copy link
Contributor

It seems this PR is ready to be merged. @victordibia do you have further comments?

Copy link
Collaborator

@victordibia victordibia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @davorrunje , tested and all works well!

@davorrunje
Copy link
Collaborator

Thanks @davorrunje , tested and all works well!

@victordibia thanx for the feedback, this is much better now

@sonichi sonichi added this pull request to the merge queue Jan 13, 2024
Merged via the queue into microsoft:main with commit b02178b Jan 13, 2024
76 of 84 checks passed
joshkyh pushed a commit that referenced this pull request Jan 17, 2024
* Preparing content for MDX v3

* upgrade dcusarus to v3

* upgrade to v3

* merge main to branch

* space

* change node version to 18

* merge main

* change setup-node version

* bug fix: added escape when needed

* added escape characters in docstrings

* upgraded docusaurus to 3.0.1

* polishing

* restored commented out link

* rename file

* removed backtick

* Add support for MD files in Docusaurus

* Add support for MD files in Docusaurus

* Add support for MD files in Docusaurus

* polishing

* cleanup

* cleanup

* cleanup

* cleanup

* cleanup

* cleanup

* cleanup

* merge with main and build scripts added

---------

Co-authored-by: Davor Runje <[email protected]>
Co-authored-by: Shaokun Zhang <[email protected]>
Co-authored-by: Victor Dibia <[email protected]>
whiskyboy pushed a commit to whiskyboy/autogen that referenced this pull request Apr 17, 2024
* Preparing content for MDX v3

* upgrade dcusarus to v3

* upgrade to v3

* merge main to branch

* space

* change node version to 18

* merge main

* change setup-node version

* bug fix: added escape when needed

* added escape characters in docstrings

* upgraded docusaurus to 3.0.1

* polishing

* restored commented out link

* rename file

* removed backtick

* Add support for MD files in Docusaurus

* Add support for MD files in Docusaurus

* Add support for MD files in Docusaurus

* polishing

* cleanup

* cleanup

* cleanup

* cleanup

* cleanup

* cleanup

* cleanup

* merge with main and build scripts added

---------

Co-authored-by: Davor Runje <[email protected]>
Co-authored-by: Shaokun Zhang <[email protected]>
Co-authored-by: Victor Dibia <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants