Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for displaying videos on AutoGen Studio #1084

Closed

Conversation

brotsky
Copy link
Contributor

@brotsky brotsky commented Dec 28, 2023

Why are these changes needed?

This fixes a problem I noticed when generating MP4 videos. The video's file type is unknown in its metadata so I used the file extension instead.

Related issue number

Checks

@brotsky
Copy link
Contributor Author

brotsky commented Dec 28, 2023

This was the problem:
Screenshot 2023-12-27 at 11 19 49 PM

And this is with my solution:
Screenshot 2023-12-27 at 11 19 06 PM

@codecov-commenter
Copy link

codecov-commenter commented Jan 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2ca8aae) 30.41% compared to head (e963b2a) 30.41%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1084   +/-   ##
=======================================
  Coverage   30.41%   30.41%           
=======================================
  Files          32       32           
  Lines        4301     4301           
  Branches      993      993           
=======================================
  Hits         1308     1308           
  Misses       2899     2899           
  Partials       94       94           
Flag Coverage Δ
unittests 30.36% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

whiskyboy pushed a commit to whiskyboy/autogen that referenced this pull request Apr 17, 2024
* Links to papers

* Update website/docs/Use-Cases/Auto-Generation.md

Co-authored-by: Qingyun Wu <[email protected]>

---------

Co-authored-by: Qingyun Wu <[email protected]>
Copy link

gitguardian bot commented Jul 20, 2024

️✅ There are no secrets present in this pull request anymore.

If these secrets were true positive and are still valid, we highly recommend you to revoke them.
Once a secret has been leaked into a git repository, you should consider it compromised, even if it was deleted immediately.
Find here more information about risks.


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@jackgerrits jackgerrits added the proj-studio Related to AutoGen Studio. label Sep 26, 2024
@ekzhu ekzhu changed the base branch from main to 0.2 October 2, 2024 18:30
@jackgerrits jackgerrits added the 0.2 Issues which are related to the pre 0.4 codebase label Oct 4, 2024
@rysweet
Copy link
Collaborator

rysweet commented Oct 10, 2024

This PR is against AutoGen 0.2. AutoGen 0.2 has been moved to the 0.2 branch. Please rebase your PR on the 0.2 branch or update it to work with the new AutoGen 0.4 that is now in main.

@rysweet rysweet added the awaiting-op-response Issue or pr has been triaged or responded to and is now awaiting a reply from the original poster label Oct 10, 2024
@victordibia
Copy link
Collaborator

Closing this as stale for now.

@rysweet
Copy link
Collaborator

rysweet commented Oct 11, 2024

actually closing it

@rysweet rysweet closed this Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0.2 Issues which are related to the pre 0.4 codebase awaiting-op-response Issue or pr has been triaged or responded to and is now awaiting a reply from the original poster proj-studio Related to AutoGen Studio.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants