-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/typo #1034
Fix/typo #1034
Conversation
@microsoft-github-policy-service agree |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These spelling fixes look good to me.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1034 +/- ##
===========================================
+ Coverage 26.54% 37.87% +11.33%
===========================================
Files 28 28
Lines 3805 3807 +2
Branches 865 907 +42
===========================================
+ Hits 1010 1442 +432
+ Misses 2724 2239 -485
- Partials 71 126 +55
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! Please check the unit test results. It looks like the some doc strings are tested for their token length.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the review. What spell check tool have you used for this PR?
All changes look good, except the failing test cases.
Thanks. The tool is pycharm's code inspections. |
* fix: typo * fix: typo * fix: typo of function name * fix: typo of function name of test file * Update test_token_count.py --------- Co-authored-by: Eric Zhu <[email protected]>
Why are these changes needed?
Fix some typographical errors to make the codes more readable.
Related issue number
Checks