[Core] Improve config_list_from_json #1026
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `env_or_file` variabe can point to an environment variable of file path.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1026 +/- ##
==========================================
+ Coverage 30.74% 40.54% +9.80%
==========================================
Files 30 30
Lines 4033 4037 +4
Branches 913 964 +51
==========================================
+ Hits 1240 1637 +397
+ Misses 2714 2289 -425
- Partials 79 111 +32
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
ekzhu
requested changes
Dec 21, 2023
There was a problem hiding this comment.
This is helpful. It also addresses the issue with VScode's Jupyter notebook environment persisting old environment variables.
Updating this example notebook too? https://github.com/microsoft/autogen/blob/main/notebook/oai_openai_utils.ipynb
ekzhu
changed the title
sonichi
reviewed
Jan 1, 2024
ekzhu
reviewed
Jan 2, 2024
whiskyboy
pushed a commit
to whiskyboy/autogen
that referenced
this pull request
Apr 17, 2024
* add 1m milestone blogpost * format issues * update subsection title * acknowledgement * Update website/blog/2023-05-07-1M-milestone/index.mdx Co-authored-by: Chi Wang <[email protected]> * Update website/blog/2023-05-07-1M-milestone/index.mdx Co-authored-by: Chi Wang <[email protected]> * update blogpost * collaborators * wording * Azure Data to Azure Synapse * name * Azure Synapse Analytics * tasks and search space * Update website/blog/2023-05-07-1M-milestone/index.mdx Co-authored-by: Chi Wang <[email protected]> --------- Co-authored-by: Chi Wang <[email protected]> Co-authored-by: Li Jiang <[email protected]>
whiskyboy
pushed a commit
to whiskyboy/autogen
that referenced
this pull request
Apr 17, 2024
* Improve config_list_from_json The `env_or_file` variabe can point to an environment variable of file path. * Update autogen/oai/openai_utils.py Co-authored-by: Chi Wang <[email protected]> * Use "with" to open config file * Remove unused. * Remove accidental added file --------- Co-authored-by: Eric Zhu <[email protected]> Co-authored-by: Chi Wang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UPDATE
The
env_or_filevariabe can point to an environment variable of file path now.In this new update, we check if the variable is a file or a json string. If it is a file, then it will load from the file.
Why are these changes needed?
It is a little bit confusing to the previous
config_list_from_jsonfunction, where the environment variable would store a JSON string. It is usually more intuitive such that an environment variable points to a file location.Related issue number
Checks