-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Core] Fix update_usage_summary when response doesn't have usage attribute #1008
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1008 +/- ##
===========================================
+ Coverage 30.82% 64.43% +33.61%
===========================================
Files 30 30
Lines 4033 4043 +10
Branches 915 964 +49
===========================================
+ Hits 1243 2605 +1362
+ Misses 2711 1167 -1544
- Partials 79 271 +192
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@kevin666aa The PR LGTM overeall. Have you tested if this sufficiently address the issue raised in #1002 and #984. Can they be closed with this PR? Is it possible to add a test here? |
I cannot replicate the error, so I can't put down a test for this. The bug is happening because I can ask people to test it out to see if it works. |
We can merge this once the conflict has been resolved. @kevin666aa |
@kevin666aa failing tests. |
Hello @ekzhu, can you help me run the openai test again? |
#1110 needs to be merged first to prevent test failures. |
…osoft#1008) * update max_spark_parallelism to fit in auto-scale spark cluster * update test
…ibute (microsoft#1008) * update cost for cache * fix test * fix bug when reponse doesn't have usage info * update setupversion * update * update * Update setup.py Co-authored-by: Chi Wang <[email protected]> --------- Co-authored-by: Qingyun Wu <[email protected]> Co-authored-by: Chi Wang <[email protected]>
Why are these changes needed?
Related issue number
Close #1002 #984
Checks