Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: Bedrock client uses incorrect environment variables for authentication #3500

Closed
seam-ctooley opened this issue Sep 9, 2024 · 4 comments
Closed

[Bug]: Bedrock client uses incorrect environment variables for authentication #3500

seam-ctooley opened this issue Sep 9, 2024 · 4 comments
Labels
0.2 Issues which are related to the pre 0.4 codebase good first issue Good for newcomers help wanted Extra attention is needed

Comments

@seam-ctooley
Copy link

Describe the bug

The AWS Bedrock client uses AWS_ACCESS_KEY and AWS_SECRET_KEY as environment variables.

autogen/autogen/oai/bedrock.py

Line 61 in 63d3297

self._aws_access_key = os.getenv("AWS_ACCESS_KEY")

Steps to reproduce

N/A

Model Used

N/A

Expected Behavior

The client should use AWS_ACCESS_KEY_ID and AWS_SECRET_ACCESS_KEY as detailed here.

Screenshots and logs

No response

Additional Information

No response
@seam-ctooley seam-ctooley changed the title [Bug]: Bedrock client uses incorrect environment variables [Bug]: Bedrock client uses incorrect environment variables for authentication Sep 9, 2024
@rysweet rysweet added 0.2 Issues which are related to the pre 0.4 codebase needs-triage labels Oct 2, 2024
@jackgerrits jackgerrits added good first issue Good for newcomers help wanted Extra attention is needed and removed needs-triage labels Oct 14, 2024
@koui-dev
Copy link

The above code is removed from the main branch in #3600 for AutoGen 0.4

Note: https://microsoft.github.io/autogen/0.2/blog/

AutoGen 0.2 is still available, developed and maintained out of the 0.2 branch. For everyone looking for a stable version, we recommend continuing to use 0.2 for the time being.

We should fix it in 0.2 if needed.

@fniedtner fniedtner removed the bug label Oct 24, 2024
@vaisakh-prod
Copy link

@seam-ctooley can i have a run at it ??

@seam-ctooley
Copy link
Author

@seam-ctooley can i have a run at it ??

Go for it

vaisakh-prod added a commit to vaisakh-prod/autogen that referenced this issue Dec 11, 2024
@vaisakh-prod
updated the aws env variable names updated ref: [Bug]: Bedrock client…
119e27c 
… uses incorrect environment variables for authentication microsoft#3500
@vaisakh-prod vaisakh-prod mentioned this issue Dec 11, 2024
Merged
3 tasks
ekzhu pushed a commit that referenced this issue Dec 12, 2024
@vaisakh-prod
[Bug]: Bedrock client uses incorrect environment variables for authen…
837b2e0 
…tication (#4657)

updated the aws env variable names updated ref: [Bug]: Bedrock client uses incorrect environment variables for authentication #3500
@ekzhu
Copy link
Collaborator

ekzhu commented Dec 12, 2024 •
edited
Loading

Fix Merged, will be available in the next 0.2 release.

@ekzhu ekzhu closed this as completed Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
0.2 Issues which are related to the pre 0.4 codebase good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
7 participants
@ekzhu @jackgerrits @rysweet @vaisakh-prod @fniedtner @koui-dev @seam-ctooley