-
Notifications
You must be signed in to change notification settings - Fork 5.6k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Register async human input handler (#794)
* Update conversable_agent.py * Add files via upload * Delete notebook/Async_human_input.ipynb * Add files via upload * refactor:formatter * feat:updated position --------- Co-authored-by: Chi Wang <[email protected]>
- Loading branch information
1 parent
c19f234
commit 5c92fb3
Showing
4 changed files
with
379 additions
and
2 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
5c92fb3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does this mean for the other contributed agents built on ConversableAgent that have a custom reply function registered at a specific position?
For example, the teachable agent registers its custom reply at position 1,
self.register_reply(Agent, TeachableAgent._generate_teachable_assistant_reply, 1)
https://github.com/microsoft/autogen/blob/7a4ba1a732ae29cb3d5c9a1b30724a4ba6891ca6/autogen/agentchat/contrib/teachable_agent.py#L66C89-L66C89
Before this commit, the TeachableAgent's custom reply would have come after
check_termination_and_human_reply
. But now, it looks like it will come aftera_check_termination_and_human_reply
but beforecheck_termination_and_human_reply
.I'm concerned about how changes to this default
register_reply
order in ConversableAgent will affect other agents that have taken a dependency on this order. Is it assumed that anything incontrib/
may experience breaking changes? Thanks!5c92fb3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is an unexpected breaking change. I overlooked the
register_reply
methods without specifying the keywordposition=
.5c92fb3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah ok. Thanks for your response!