Enable stable branding for release 9.3 #9289
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -33,7 +33,7 @@ | |||||||||||||||
| `AspireProjectOrPackageReference` - maps to projects in `src/` or `src/Components/` | ||||||||||||||||
| --> | ||||||||||||||||
|
|
||||||||||||||||
| <Import Project="Sdk.props" Sdk="Aspire.AppHost.Sdk" Version="9.3.0" Condition="'$(IsAspireHost)' == 'true' and '$(RepoRoot)' == '' and '$(TestsRunningOutsideOfRepo)' == 'true'" /> | ||||||||||||||||
|
Member
There was a problem hiding this comment. Do we do this hardcoding every time?
Member
Author
There was a problem hiding this comment. I'd love for that not to be the case but we haven't made the work to fix it. Main issue is that PackageVersion can't be used as that is a variable that changes depending on the project you are building, so when you are emitting a reference (like in this case or in the Directory.Packages.Helix.props) to a different package getting built, you don't want to use This is not super trivial and we haven't been able to prioritize it, so for now, we have to hard code each time we stabilize, but I'd love to not have to do this in the future :) |
||||||||||||||||
|
|
||||||||||||||||
| <PropertyGroup> | ||||||||||||||||
|
Comment on lines
+36
to
38
There was a problem hiding this comment. [nitpick] Hardcoding the SDK version can lead to more churn each release. Consider referencing a centralized version property (e.g.,
Suggested change
|
||||||||||||||||
| <!-- copy by default only when archiving tests, and for test projects that support running out of repo --> | ||||||||||||||||
|
|
@@ -160,6 +160,6 @@ | |||||||||||||||
| <AspireHostingSDKVersion>$(MajorVersion).$(MinorVersion).$(PatchVersion)</AspireHostingSDKVersion> | ||||||||||||||||
| </PropertyGroup> | ||||||||||||||||
|
|
||||||||||||||||
| <Import Project="Sdk.targets" Sdk="Aspire.AppHost.Sdk" Version="9.3.0" Condition="'$(IsAspireHost)' == 'true' and '$(RepoRoot)' == '' and '$(TestsRunningOutsideOfRepo)' == 'true'" /> | ||||||||||||||||
|
|
||||||||||||||||
| </Project> | ||||||||||||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -3,88 +3,88 @@ | |
|
|
||
| <ItemGroup Label="Aspire packages"> | ||
| <PackageVersion Include="Aspire.Azure.AI.OpenAI" Version="$(PackageVersion)" /> | ||
|
Member
Author
There was a problem hiding this comment. Because this package is not going to get stable yet so no need to stabilize the reference: |
||
| <PackageVersion Include="Aspire.Azure.Data.Tables" Version="9.3.0" /> | ||
| <PackageVersion Include="Aspire.Azure.Messaging.EventHubs" Version="9.3.0" /> | ||
| <PackageVersion Include="Aspire.Azure.Messaging.ServiceBus" Version="9.3.0" /> | ||
|
|
||
| <PackageVersion Include="Aspire.Azure.Messaging.WebPubSub" Version="9.3.0" /> | ||
| <PackageVersion Include="Aspire.Azure.Search.Documents" Version="9.3.0" /> | ||
| <PackageVersion Include="Aspire.Azure.Security.KeyVault" Version="9.3.0" /> | ||
| <PackageVersion Include="Aspire.Azure.Storage.Blobs" Version="9.3.0" /> | ||
| <PackageVersion Include="Aspire.Azure.Storage.Queues" Version="9.3.0" /> | ||
| <PackageVersion Include="Aspire.Azure.Npgsql.EntityFrameworkCore.PostgreSQL" Version="9.3.0" /> | ||
| <PackageVersion Include="Aspire.Confluent.Kafka" Version="9.3.0" /> | ||
| <PackageVersion Include="Aspire.Elastic.Clients.Elasticsearch" Version="9.3.0" /> | ||
|
|
||
| <PackageVersion Include="Aspire.Hosting" Version="9.3.0" /> | ||
| <PackageVersion Include="Aspire.Hosting.AppHost" Version="9.3.0" /> | ||
| <PackageVersion Include="Aspire.Hosting.Azure" Version="9.3.0" /> | ||
| <PackageVersion Include="Aspire.Hosting.Azure.AppConfiguration" Version="9.3.0" /> | ||
| <PackageVersion Include="Aspire.Hosting.Azure.ApplicationInsights" Version="9.3.0" /> | ||
| <PackageVersion Include="Aspire.Hosting.Azure.CognitiveServices" Version="9.3.0" /> | ||
| <PackageVersion Include="Aspire.Hosting.Azure.CosmosDB" Version="9.3.0" /> | ||
| <PackageVersion Include="Aspire.Hosting.Azure.ContainerRegistry" Version="$(PackageVersion)" /> | ||
| <PackageVersion Include="Aspire.Hosting.Azure.EventHubs" Version="9.3.0" /> | ||
| <PackageVersion Include="Aspire.Hosting.Azure.Functions" Version="$(PackageVersion)" /> | ||
| <PackageVersion Include="Aspire.Hosting.Azure.KeyVault" Version="9.3.0" /> | ||
| <PackageVersion Include="Aspire.Hosting.Azure.OperationalInsights" Version="9.3.0" /> | ||
|
Comment on lines
4
to
+29
There was a problem hiding this comment. [nitpick] The version literal |
||
| <PackageVersion Include="Aspire.Hosting.Azure.PostgreSQL" Version="9.3.0" /> | ||
| <PackageVersion Include="Aspire.Hosting.Azure.Redis" Version="9.3.0" /> | ||
| <PackageVersion Include="Aspire.Hosting.Azure.Search" Version="9.3.0" /> | ||
| <PackageVersion Include="Aspire.Hosting.Azure.ServiceBus" Version="9.3.0" /> | ||
| <PackageVersion Include="Aspire.Hosting.Azure.SignalR" Version="9.3.0" /> | ||
| <PackageVersion Include="Aspire.Hosting.Azure.Sql" Version="9.3.0" /> | ||
| <PackageVersion Include="Aspire.Hosting.Azure.Storage" Version="9.3.0" /> | ||
| <PackageVersion Include="Aspire.Hosting.Azure.WebPubSub" Version="9.3.0" /> | ||
| <PackageVersion Include="Aspire.Hosting.Docker" Version="$(PackageVersion)" /> | ||
| <PackageVersion Include="Aspire.Hosting.Elasticsearch" Version="9.3.0" /> | ||
| <PackageVersion Include="Aspire.Hosting.Garnet" Version="9.3.0" /> | ||
| <PackageVersion Include="Aspire.Hosting.Kafka" Version="9.3.0" /> | ||
| <PackageVersion Include="Aspire.Hosting.Keycloak" Version="$(PackageVersion)" /> | ||
| <PackageVersion Include="Aspire.Hosting.Milvus" Version="9.3.0" /> | ||
| <PackageVersion Include="Aspire.Hosting.MongoDB" Version="9.3.0" /> | ||
| <PackageVersion Include="Aspire.Hosting.MySql" Version="9.3.0" /> | ||
| <PackageVersion Include="Aspire.Hosting.Nats" Version="9.3.0" /> | ||
| <PackageVersion Include="Aspire.Hosting.NodeJs" Version="9.3.0" /> | ||
| <PackageVersion Include="Aspire.Hosting.Oracle" Version="9.3.0" /> | ||
| <PackageVersion Include="Aspire.Hosting.Orleans" Version="9.3.0" /> | ||
| <PackageVersion Include="Aspire.Hosting.PostgreSQL" Version="9.3.0" /> | ||
| <PackageVersion Include="Aspire.Hosting.Python" Version="9.3.0" /> | ||
| <PackageVersion Include="Aspire.Hosting.Qdrant" Version="9.3.0" /> | ||
| <PackageVersion Include="Aspire.Hosting.RabbitMQ" Version="9.3.0" /> | ||
| <PackageVersion Include="Aspire.Hosting.Redis" Version="9.3.0" /> | ||
| <PackageVersion Include="Aspire.AppHost.Sdk" Version="9.3.0" /> | ||
| <PackageVersion Include="Aspire.Hosting.Seq" Version="9.3.0" /> | ||
| <PackageVersion Include="Aspire.Hosting.SqlServer" Version="9.3.0" /> | ||
| <PackageVersion Include="Aspire.Hosting.Testing" Version="9.3.0" /> | ||
| <PackageVersion Include="Aspire.Hosting.Valkey" Version="9.3.0" /> | ||
| <PackageVersion Include="Aspire.Hosting.Yarp" Version="$(PackageVersion)" /> | ||
|
|
||
| <PackageVersion Include="Aspire.Keycloak.Authentication" Version="$(PackageVersion)" /> | ||
| <PackageVersion Include="Aspire.Microsoft.Azure.Cosmos" Version="9.3.0" /> | ||
| <PackageVersion Include="Aspire.Microsoft.Data.SqlClient" Version="9.3.0" /> | ||
| <PackageVersion Include="Aspire.Microsoft.EntityFrameworkCore.Cosmos" Version="9.3.0" /> | ||
| <PackageVersion Include="Aspire.Microsoft.EntityFrameworkCore.SqlServer" Version="9.3.0" /> | ||
| <PackageVersion Include="Aspire.Milvus.Client" Version="$(PackageVersion)" /> | ||
| <PackageVersion Include="Aspire.MongoDB.Driver" Version="9.3.0" /> | ||
| <PackageVersion Include="Aspire.MongoDB.Driver.v3" Version="9.3.0" /> | ||
| <PackageVersion Include="Aspire.MySqlConnector" Version="9.3.0" /> | ||
| <PackageVersion Include="Aspire.NATS.Net" Version="9.3.0" /> | ||
| <PackageVersion Include="Aspire.Npgsql" Version="9.3.0" /> | ||
| <PackageVersion Include="Aspire.Npgsql.EntityFrameworkCore.PostgreSQL" Version="9.3.0" /> | ||
| <PackageVersion Include="Aspire.Oracle.EntityFrameworkCore" Version="9.3.0" /> | ||
| <PackageVersion Include="Aspire.Pomelo.EntityFrameworkCore.MySql" Version="9.3.0" /> | ||
| <PackageVersion Include="Aspire.Qdrant.Client" Version="9.3.0" /> | ||
| <PackageVersion Include="Aspire.RabbitMQ.Client" Version="9.3.0" /> | ||
| <PackageVersion Include="Aspire.RabbitMQ.Client.v7" Version="9.3.0" /> | ||
| <PackageVersion Include="Aspire.Seq" Version="9.3.0" /> | ||
| <PackageVersion Include="Aspire.StackExchange.Redis" Version="9.3.0" /> | ||
| <PackageVersion Include="Aspire.StackExchange.Redis.DistributedCaching" Version="9.3.0" /> | ||
| <PackageVersion Include="Aspire.StackExchange.Redis.OutputCaching" Version="9.3.0" /> | ||
|
|
||
| <PackageVersion Include="Microsoft.Extensions.ServiceDiscovery" Version="9.3.0" /> | ||
| <PackageVersion Include="Microsoft.Extensions.ServiceDiscovery.Abstractions" Version="9.3.0" /> | ||
| <PackageVersion Include="Microsoft.Extensions.ServiceDiscovery.Dns" Version="9.3.0" /> | ||
| <PackageVersion Include="Microsoft.Extensions.ServiceDiscovery.Yarp" Version="9.3.0" /> | ||
| </ItemGroup> | ||
|
|
||
| <ItemGroup Label="For tests"> | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.