bump overall test library timeout to 20m because of slow sqlserver tests#8806
Merged
danmoseley merged 3 commits intomicrosoft:mainfrom Apr 16, 2025
Merged
bump overall test library timeout to 20m because of slow sqlserver tests#8806danmoseley merged 3 commits intomicrosoft:mainfrom
danmoseley merged 3 commits intomicrosoft:mainfrom
Conversation
github-actions
bot
added
the
area-engineering-systems
danmoseley
changed the title
Member
Author
|
@radical thoughts? |
Member
Author
|
well that was green @radical . if you sign off we can merge. I assume the first one is for everything, the second one an override for Helix - is that what you intended? seems fine |
Member
Yeah, for now it will be for all tests on helix. We could do something like https://github.com/dotnet/aspire/blob/0842b7cb48778f4f6f1d02f74c4f489bc4820b04/tests/helix/send-to-helix-basictests.targets#L24-L25 .. but I don't know the name of the relevant setting here, and this will change when the MTP changes are applied again. |
radical
approved these changes
Apr 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Aspire.Hosting.SqlServer.Tests regularly hits the 10 min timeout in rolling builds.
@radical is there some way to make the timeout specific to this test library?
This will conflict with #8802