Don't fail for Azure role assignments in run mode#8800
Merged
danmoseley merged 2 commits intomicrosoft:mainfrom Apr 16, 2025
Merged
Don't fail for Azure role assignments in run mode#8800danmoseley merged 2 commits intomicrosoft:mainfrom
danmoseley merged 2 commits intomicrosoft:mainfrom
Conversation
We are throwing too early. When users only want to dotnet run their app and use role assignments, we shouldn't be blocking them on using role assignments. Only when you go to publish, should we throw saying that your infrastructure doesn't support targeted role assignments. Fix microsoft#8778
github-actions
bot
added
the
area-integrations
…sources. In those cases we still want the default role assignments to apply.
davidfowl
approved these changes
Apr 16, 2025
Member
Author
|
/backport to release/9.2 |
Contributor
|
Started backporting to release/9.2: https://github.com/dotnet/aspire/actions/runs/14483293786 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
We are throwing too early. When users only want to dotnet run their app and use role assignments, we shouldn't be blocking them on using role assignments. Only when you go to publish, should we throw saying that your infrastructure doesn't support targeted role assignments.
Fix #8778
Checklist