Skip to content

Fix AE in ExecutableResource#8797

Merged
danmoseley merged 8 commits intomicrosoft:mainfrom
danmoseley:fixArgEx
Apr 17, 2025
Merged

Fix AE in ExecutableResource#8797
danmoseley merged 8 commits intomicrosoft:mainfrom
danmoseley:fixArgEx

Conversation

@danmoseley
Copy link
Member

@danmoseley danmoseley commented Apr 15, 2025

Description

Fixes #8732

We made the same 9.1->9.2 break in the Command property also but I think that should be maintained since Process.Start requires one (unless there's a Windows shell style verb, which we don't use)

I looked through the original change and found no other examples of empty string becoming disallowed beyond these two

Checklist

  • Is this feature complete?
    • Yes. Ready to ship.
    • No. Follow-up changes expected.
  • Are you including unit tests for the changes and scenario tests if relevant?
    • Yes
    • No
  • Did you add public API?
    • Yes
      • If yes, did you have an API Review for it?
        • Yes
        • No
      • Did you add <remarks /> and <code /> elements on your triple slash comments?
        • Yes
        • No
    • No
  • Does the change make any security assumptions or guarantees?
    • Yes
      • If yes, have you done a threat model and had a security review?
        • Yes
        • No
    • No
  • Does the change require an update in our Aspire docs?

@danmoseley danmoseley requested a review from mitchdenny as a code owner April 15, 2025 21:14
@github-actions github-actions bot added the area-app-model Issues pertaining to the APIs in Aspire.Hosting, e.g. DistributedApplication label Apr 15, 2025
@danmoseley
Copy link
Member Author

/backport to release/9.2

@github-actions
Copy link
Contributor

@danmoseley
Copy link
Member Author

temporarily reverting the fix part to investigate test failure

@danmoseley danmoseley added the NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) label Apr 16, 2025
@danmoseley danmoseley marked this pull request as draft April 16, 2025 01:57
@danmoseley
Copy link
Member Author

Well wierd, back to original state and now it's all green. Must have been an issue in main...

@danmoseley danmoseley marked this pull request as ready for review April 17, 2025 23:10
@danmoseley danmoseley merged commit 630a233 into microsoft:main Apr 17, 2025
175 checks passed
@danmoseley danmoseley deleted the fixArgEx branch April 17, 2025 23:10
@danmoseley
Copy link
Member Author

/backport to release/9.2

@github-actions
Copy link
Contributor

@danmoseley
Copy link
Member Author

/backport to release/9.2

@github-actions
Copy link
Contributor

@danmoseley
Copy link
Member Author

Patched in 9.2.1. To pick up this fix if you need it,

For existing projects targeting 9.2.0, please update as follows;
<Sdk Name="Aspire.AppHost.Sdk" Version="9.2.0" /> to <Sdk Name="Aspire.AppHost.Sdk" Version="9.2.1" /> and
<PackageReference Include="Aspire...." Version="9.2.0" /> to <PackageReference Include="Aspire...." Version="9.2.1" /> and restore packages.

If you're creating new projects, you can just install and use the updated project templates: dotnet new install Aspire.ProjectTemplates::9.2.1 --force

@github-actions github-actions bot locked and limited conversation to collaborators May 26, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-app-model Issues pertaining to the APIs in Aspire.Hosting, e.g. DistributedApplication NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ExecutableResource no longer accepted string.Empty for the working directory

2 participants