[release/9.2]: Ensure visible trace spans stay sorted by start time#8785
Closed
adamint wants to merge 2 commits intomicrosoft:release/9.2from
Closed
[release/9.2]: Ensure visible trace spans stay sorted by start time#8785adamint wants to merge 2 commits intomicrosoft:release/9.2from
adamint wants to merge 2 commits intomicrosoft:release/9.2from
Conversation
Member
Author
Member
|
There have been changes to #8771 after this was backported. |
Member
|
Closing and re-opening to run checks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #8771 to release/9.2
Customer Impact
This PR changes the dashboard trace detail data provider to replace an unordered data structure with an ordered one w/comparer to ensure that span ordering by time is preserved.
Testing
A unit test has been added and a diff is included in the original PR if manual testing is desired as well.
Risk
This is a small, isolated, tested change where the root cause is well understood.
Regression?
Yes