[release/9.1] Fix arg annotations when running in IDE mode#7722
Merged
danmoseley merged 4 commits intorelease/9.1from Feb 21, 2025
Merged
[release/9.1] Fix arg annotations when running in IDE mode#7722danmoseley merged 4 commits intorelease/9.1from
danmoseley merged 4 commits intorelease/9.1from
Conversation
Member
|
bed9a2a to
4ee190a
Compare
davidfowl
approved these changes
Feb 21, 2025
Member
|
@danmoseley Looks like a transient error. |
danmoseley
approved these changes
Feb 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #7711 to release/9.1
/cc @danmoseley @JamesNK
Customer Impact
.NET projects can be configured with command line args in their launch profile and in the app host. The dashboard displays them to the user.
There are two modes of running .NET projects: IDE and process. The dashboard is displaying args to the user incorrectly in IDE mode. It combines the args from the profile and app host, but it should be using only the app host args if present, then falling back to the profile args.
The impact here is user confusion about the args they see in the dashboard vs the args that project is run with.
Testing
Unit tests and manual testing.
Args here -
--port 7071- correctly aren't duplicated:Risk
Medium. The PR changes how args are calculated for .NET projects. It's important code to get right.
Regression?
No. In 9.0 args were never shown for .NET projects.