Skip to content

[release/9.1] Fix arg annotations when running in IDE mode#7722

Merged
danmoseley merged 4 commits intorelease/9.1from
backport/pr-7711-to-release/9.1
Feb 21, 2025
Merged

[release/9.1] Fix arg annotations when running in IDE mode#7722
danmoseley merged 4 commits intorelease/9.1from
backport/pr-7711-to-release/9.1

Conversation

@github-actions
Copy link
Contributor

@github-actions github-actions bot commented Feb 20, 2025

Backport of #7711 to release/9.1

/cc @danmoseley @JamesNK

Customer Impact

.NET projects can be configured with command line args in their launch profile and in the app host. The dashboard displays them to the user.

There are two modes of running .NET projects: IDE and process. The dashboard is displaying args to the user incorrectly in IDE mode. It combines the args from the profile and app host, but it should be using only the app host args if present, then falling back to the profile args.

The impact here is user confusion about the args they see in the dashboard vs the args that project is run with.

Testing

Unit tests and manual testing.

Args here - --port 7071 - correctly aren't duplicated:

image

Risk

Medium. The PR changes how args are calculated for .NET projects. It's important code to get right.

Regression?

No. In 9.0 args were never shown for .NET projects.

@github-actions github-actions bot requested a review from mitchdenny as a code owner February 20, 2025 20:27
@danmoseley danmoseley closed this Feb 20, 2025
@danmoseley danmoseley reopened this Feb 20, 2025
@danmoseley
Copy link
Member

fail: TestingAppHost1.AppHost.Resources.postgres1[0]
      42: 2025-02-20T20:36:13.2122340Z 2025-02-20 20:36:13.211 UTC [1] LOG:  starting PostgreSQL 17.2 (Debian 17.2-1.pgdg120+1) on x86_64-pc-linux-gnu, compiled by gcc (Debian 12.2.0-14) 12.2.0, 64-bit
fail: TestingAppHost1.AppHost.Resources.postgres1[0]
      43: 2025-02-20T20:36:13.2122779Z 2025-02-20 20:36:13.211 UTC [1] LOG:  listening on IPv4 address "0.0.0.0", port 5432
fail: TestingAppHost1.AppHost.Resources.postgres1[0]
      44: 2025-02-20T20:36:13.2122847Z 2025-02-20 20:36:13.211 UTC [1] LOG:  listening on IPv6 address "::", port 5432
fail: TestingAppHost1.AppHost.Resources.postgres1[0]
      45: 2025-02-20T20:36:13.2132724Z 2025-02-20 20:36:13.213 UTC [1] LOG:  listening on Unix socket "/var/run/postgresql/.s.PGSQL.5432"
fail: TestingAppHost1.AppHost.Resources.postgres1[0]
      46: 2025-02-20T20:36:13.2170400Z 2025-02-20 20:36:13.216 UTC [61] LOG:  database system was shut down at 2025-02-20 20:36:13 UTC
fail: TestingAppHost1.AppHost.Resources.postgres1[0]
      47: 2025-02-20T20:36:13.2226045Z 2025-02-20 20:36:13.222 UTC [1] LOG:  database system is ready to accept connections

@github-actions github-actions bot force-pushed the backport/pr-7711-to-release/9.1 branch from bed9a2a to 4ee190a Compare February 20, 2025 23:49
@JamesNK
Copy link
Member

JamesNK commented Feb 21, 2025

@danmoseley Looks like a transient error.

@danmoseley danmoseley added the Servicing-approved Approved for servicing release label Feb 21, 2025
@danmoseley danmoseley merged commit 89d5b4a into release/9.1 Feb 21, 2025
5 checks passed
@danmoseley danmoseley deleted the backport/pr-7711-to-release/9.1 branch February 21, 2025 00:28
@github-actions github-actions bot locked and limited conversation to collaborators Mar 23, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-dashboard Servicing-approved Approved for servicing release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants