Skip to content

[release/9.1] Allow for nested children in the dashboard#7613

Merged
davidfowl merged 2 commits intorelease/9.1from
backport/pr-7604-to-release/9.1
Feb 14, 2025
Merged

[release/9.1] Allow for nested children in the dashboard#7613
davidfowl merged 2 commits intorelease/9.1from
backport/pr-7604-to-release/9.1

Conversation

@github-actions
Copy link
Contributor

@github-actions github-actions bot commented Feb 14, 2025

Backport of #7604 to release/9.1

/cc @eerhardt

Customer Impact

When customers use CosmosDB, EventHubs, ServiceBus, or any other resource that has more than 1 level of children, the 2nd level children show directly under the parent.

Before

image

After

image

Testing

Manual using the playground apps. Plus added unit tests.

Risk

The risk is that we mess up single level children nesting, or raise new errors that weren't there before. This risk is pretty low though.

Regression?

No

Originally the parent-child lookup contained the "root" parent and all the descendants in a flat list. This doesn't show up well in the dashboard because grandchildren are parented directly under their root.

Fix this by making the parent-child lookup only contain direct children, and recursively parent the descendants on their direct parent.

Fix #7580
@davidfowl davidfowl merged commit 9bba310 into release/9.1 Feb 14, 2025
5 checks passed
@davidfowl davidfowl deleted the backport/pr-7604-to-release/9.1 branch February 14, 2025 15:55
@github-actions github-actions bot added the area-app-model Issues pertaining to the APIs in Aspire.Hosting, e.g. DistributedApplication label Mar 10, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Apr 9, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-app-model Issues pertaining to the APIs in Aspire.Hosting, e.g. DistributedApplication

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants