[release/9.1] Allow for nested children in the dashboard#7613
Merged
davidfowl merged 2 commits intorelease/9.1from Feb 14, 2025
Merged
[release/9.1] Allow for nested children in the dashboard#7613davidfowl merged 2 commits intorelease/9.1from
davidfowl merged 2 commits intorelease/9.1from
Conversation
Originally the parent-child lookup contained the "root" parent and all the descendants in a flat list. This doesn't show up well in the dashboard because grandchildren are parented directly under their root. Fix this by making the parent-child lookup only contain direct children, and recursively parent the descendants on their direct parent. Fix #7580
DamianEdwards
approved these changes
Feb 14, 2025
davidfowl
approved these changes
Feb 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #7604 to release/9.1
/cc @eerhardt
Customer Impact
When customers use CosmosDB, EventHubs, ServiceBus, or any other resource that has more than 1 level of children, the 2nd level children show directly under the parent.
Before
After
Testing
Manual using the playground apps. Plus added unit tests.
Risk
The risk is that we mess up single level children nesting, or raise new errors that weren't there before. This risk is pretty low though.
Regression?
No