[release/8.0-preview1] Azure cosmosdb support in aspire (#359)#669
Merged
davidfowl merged 1 commit intorelease/8.0-preview1from Nov 2, 2023
Merged
[release/8.0-preview1] Azure cosmosdb support in aspire (#359)#669davidfowl merged 1 commit intorelease/8.0-preview1from
davidfowl merged 1 commit intorelease/8.0-preview1from
Conversation
* Initial addition of CosmosDB support, based on SqlServer * Remove Healthchecks support from CosmosDB EF Component * Cleanup connection string handling in Cosmos EF * Cleanup connection string handling in Cosmos component * Update CosmosDB package to get OTel support * Use the parent name for the connection * Udpate manifest strings * Add CosmosDB components to Progress and Telemetry * Rename CosmosDB components to Aspire.Azure.Data.Cosmos[.EntityFrameworkCore] * Rename options -> settings * Rename Cosmos Components to follow naming guidelines * Update to CosmosDB preview package and pin to get OpenTelemetry support * Update comments and add Keyed DI to Aspire.Microsoft.Azure.Cosmos * Add log categories to Cosmos Component schemas * Add basic support for CosmosClientOptions (no IConfiguration binding yet) * Remove healthchecks support from CosmosDB Component * Add README for Aspire.Microsoft.Azure.Cosmos * Add README for Aspire.Microsoft.EntityFrameworkCore.Cosmos, and rename a couple of things * Update config schema to be nested for Aspire.Microsoft.EntityFramework.Cosmos and Aspire.Microsoft.Azure.Cosmos * Rename AzureDataCosmosSettings -> AzureCosmosDBSettings * Update Aspire_Components_Progress.md * Add PackageTags, Descriptions, and Icons * Add AccountEndpoint to ConfigurationScheama.json * Fix DB context builder config * Add xml doc comments for CosmosDB hosting methods and types * Move Cosmos DB hosting to Aspire.Hosting.Azure * Update manifest type names * Respond to PR feedback
eerhardt
requested review from
DamianEdwards,
Pilchie,
danmoseley and
davidfowl
Pilchie
approved these changes
Nov 2, 2023
davidfowl
approved these changes
Nov 2, 2023
mitchdenny
approved these changes
Nov 2, 2023
Closed
danmoseley
added
the
area-integrations
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Port #359 to release/8.0-preview1
Initial addition of CosmosDB support, based on SqlServer
Remove Healthchecks support from CosmosDB EF Component
Cleanup connection string handling in Cosmos EF
Cleanup connection string handling in Cosmos component
Update CosmosDB package to get OTel support
Use the parent name for the connection
Udpate manifest strings
Add CosmosDB components to Progress and Telemetry
Rename CosmosDB components to Aspire.Azure.Data.Cosmos[.EntityFrameworkCore]
Rename options -> settings
Rename Cosmos Components to follow naming guidelines
Update to CosmosDB preview package and pin to get OpenTelemetry support
Update comments and add Keyed DI to Aspire.Microsoft.Azure.Cosmos
Add log categories to Cosmos Component schemas
Add basic support for CosmosClientOptions (no IConfiguration binding yet)
Remove healthchecks support from CosmosDB Component
Add README for Aspire.Microsoft.Azure.Cosmos
Add README for Aspire.Microsoft.EntityFrameworkCore.Cosmos, and rename a couple of things
Update config schema to be nested for Aspire.Microsoft.EntityFramework.Cosmos and Aspire.Microsoft.Azure.Cosmos
Rename AzureDataCosmosSettings -> AzureCosmosDBSettings
Update Aspire_Components_Progress.md
Add PackageTags, Descriptions, and Icons
Add AccountEndpoint to ConfigurationScheama.json
Fix DB context builder config
Add xml doc comments for CosmosDB hosting methods and types
Move Cosmos DB hosting to Aspire.Hosting.Azure
Update manifest type names
Respond to PR feedback