Merged
Conversation
mitchdenny
commented
Oct 25, 2024
mitchdenny
commented
Oct 25, 2024
mitchdenny
commented
Oct 25, 2024
mitchdenny
commented
Oct 25, 2024
mitchdenny
commented
Oct 25, 2024
mitchdenny
commented
Oct 25, 2024
mitchdenny
commented
Oct 25, 2024
mitchdenny
commented
Oct 25, 2024
mitchdenny
commented
Oct 25, 2024
mitchdenny
commented
Oct 25, 2024
mitchdenny
commented
Oct 25, 2024
Member
Author
|
Couple of gotchas. For forwarded ports, it can take some time for Codespaces to generate the TLS cert for the endpoint. You just have to be patient. Part of explicitly forwarding the ports in the |
94c55e5 to
51e8389
Compare
mitchdenny
commented
Oct 28, 2024
mitchdenny
commented
Oct 28, 2024
davidfowl
reviewed
Oct 28, 2024
eerhardt
reviewed
Oct 28, 2024
Co-authored-by: Eric Erhardt <eric.erhardt@microsoft.com>
Co-authored-by: Eric Erhardt <eric.erhardt@microsoft.com>
Co-authored-by: Eric Erhardt <eric.erhardt@microsoft.com>
Co-authored-by: Eric Erhardt <eric.erhardt@microsoft.com>
Co-authored-by: Eric Erhardt <eric.erhardt@microsoft.com>
Open
3 tasks
davidfowl
approved these changes
Oct 29, 2024
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
|
@mitchdenny one place where we don't detect the codespace and print the right url is here:
We should change this too. |
Member
Author
|
Yeah I was looking at this I made some tweaks last night as an experiment. I can put up a PR. |
Contributor
|
Also it seems like only certain playground examples work? |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description
This is an initial PR to enable devcontainer support in the repo. The goal is to enable the various remote development scenarios (Codespaces, SSH, etc) so that we can test them. This is important because we've added logic to the apphost that can do things like detect it is running in Codespaces and using the Aspire repo under Codespaces is a good way of casually validating everything is working.
Outstanding issues
Fixes # (issue)
Checklist
<remarks />and<code />elements on your triple slash comments?Microsoft Reviewers: Open in CodeFlow