Skip to content

Fix restart of containers that use a dockerfile#6422

Merged
karolz-ms merged 1 commit intomainfrom
dev/karolz/issue6392
Oct 22, 2024
Merged

Fix restart of containers that use a dockerfile#6422
karolz-ms merged 1 commit intomainfrom
dev/karolz/issue6392

Conversation

@karolz-ms
Copy link
Contributor

@karolz-ms karolz-ms commented Oct 21, 2024

Description

Adjust timeouts and retry policy for request made from app host to DCP.

Fixes #6392

Checklist

  • Is this feature complete?
    • Yes. Ready to ship.
    • No. Follow-up changes expected.
  • Are you including unit tests for the changes and scenario tests if relevant?
    • Yes
    • No (N/A)
  • Did you add public API?
    • Yes
      • If yes, did you have an API Review for it?
        • Yes
        • No
      • Did you add <remarks /> and <code /> elements on your triple slash comments?
        • Yes
        • No
    • No
  • Does the change make any security assumptions or guarantees?
    • Yes
      • If yes, have you done a threat model and had a security review?
        • Yes
        • No
    • No
  • Does the change require an update in our Aspire docs?
    • Yes
      • Link to aspire-docs issue:
    • No
Microsoft Reviewers: Open in CodeFlow

@davidfowl
Copy link
Contributor

This needs a backport

@karolz-ms karolz-ms enabled auto-merge (squash) October 22, 2024 00:08
@karolz-ms
Copy link
Contributor Author

/backport to release/9.0

@github-actions
Copy link
Contributor

Copy link
Member

@mitchdenny mitchdenny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ... ran this locally.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-app-model Issues pertaining to the APIs in Aspire.Hosting, e.g. DistributedApplication

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Restarting containers using docker file fails

4 participants