Skip to content

Update package tags for "integration" and "library" terms#5403

Merged
DamianEdwards merged 4 commits intomainfrom
damianedwards/package-tags-update
Aug 23, 2024
Merged

Update package tags for "integration" and "library" terms#5403
DamianEdwards merged 4 commits intomainfrom
damianedwards/package-tags-update

Conversation

@DamianEdwards
Copy link
Member

@DamianEdwards DamianEdwards commented Aug 23, 2024

Updates the package tags to use the "integration" term. The previously termed "component" packages have "library" added also, so we have "integration hosting" packages and "integration library" packages. The "component" tag isn't being removed as yet as the Visual Studio "Add Aspire package" experience still relies on it.

@ghost ghost added the area-integrations Issues pertaining to Aspire Integrations packages label Aug 23, 2024
Copy link
Member

@eerhardt eerhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DamianEdwards DamianEdwards enabled auto-merge (squash) August 23, 2024 21:22
@eerhardt
Copy link
Member

/backport to release/8.2

@github-actions
Copy link
Contributor

@DamianEdwards
Copy link
Member Author

Failure looks like a Helix job timeout. Is this common @radical?

@radical
Copy link
Member

radical commented Aug 23, 2024

Failure looks like a Helix job timeout. Is this common @radical?

Only the Cosmos failure in Aspire.Playground.Tests is known to fail sometimes.

The other two:

  1. Mysql - times out waiting for s_mySqlReadyText = log => log.Contains("ready for connections") && log.Contains("port: 3306");.

  2. RabbitMQ is timing out after 1 minute because the docker image was being pulled before the container could be started.

For a separate PR: We should add WaitForResources in general before WaitForTextAsync in the tests.

@radical
Copy link
Member

radical commented Aug 23, 2024

We should add WaitForResources in general before WaitForTextAsync in the tests.

Opened #5414

@DamianEdwards DamianEdwards merged commit 03d22f5 into main Aug 23, 2024
@DamianEdwards DamianEdwards deleted the damianedwards/package-tags-update branch August 23, 2024 23:57
@github-actions github-actions bot locked and limited conversation to collaborators Sep 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-integrations Issues pertaining to Aspire Integrations packages

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants