Skip to content

CA1062#Aspire.Hosting.Redis#Path-1 #5121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
radical merged 1 commit into from
Jul 30, 2024
Merged

CA1062#Aspire.Hosting.Redis#Path-1 #5121

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
101 changes: 35 additions & 66 deletions tests/Aspire.Hosting.Redis.Tests/RedisPublicApiTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
// The .NET Foundation licenses this file to you under the MIT license.

using Aspire.Hosting.ApplicationModel;
using Aspire.Hosting.Utils;
using Xunit;

namespace Aspire.Hosting.Redis.Tests;
Expand All @@ -11,131 +12,105 @@ public class RedisPublicApiTests
#region RedisBuilderExtensions

[Fact]
public void AddRedisContainerShouldThrowsWhenBuilderIsNull()
public void AddRedisContainerShouldThrowWhenBuilderIsNull()
{
IDistributedApplicationBuilder builder = null!;
const string name = "Redis";

var action = () => builder.AddRedis(name);

Assert.Multiple(() =>
{
var exception = Assert.Throws<ArgumentNullException>(action);
Assert.Equal(nameof(builder), exception.ParamName);
});
var exception = Assert.Throws<ArgumentNullException>(action);
Assert.Equal(nameof(builder), exception.ParamName);
}

[Fact]
public void AddRedisContainerShouldThrowsWhenNameIsNull()
public void AddRedisContainerShouldThrowWhenNameIsNull()
{
IDistributedApplicationBuilder builder = new DistributedApplicationBuilder([]);
string name = null!;

var action = () => builder.AddRedis(name);

Assert.Multiple(() =>
{
var exception = Assert.Throws<ArgumentNullException>(action);
Assert.Equal(nameof(name), exception.ParamName);
});
var exception = Assert.Throws<ArgumentNullException>(action);
Assert.Equal(nameof(name), exception.ParamName);
}

[Fact]
public void WithRedisCommanderShouldThrowsWhenBuilderIsNull()
public void WithRedisCommanderShouldThrowWhenBuilderIsNull()
{
IResourceBuilder<RedisResource> builder = null!;

var action = () => builder.WithRedisCommander();

Assert.Multiple(() =>
{
var exception = Assert.Throws<ArgumentNullException>(action);
Assert.Equal(nameof(builder), exception.ParamName);
});
var exception = Assert.Throws<ArgumentNullException>(action);
Assert.Equal(nameof(builder), exception.ParamName);
}

[Fact]
public void WithHostPortShouldThrowsWhenBuilderIsNull()
public void WithHostPortShouldThrowWhenBuilderIsNull()
{
IResourceBuilder<RedisCommanderResource> builder = null!;
const int port = 777;

var action = () => builder.WithHostPort(port);

Assert.Multiple(() =>
{
var exception = Assert.Throws<ArgumentNullException>(action);
Assert.Equal(nameof(builder), exception.ParamName);
});
var exception = Assert.Throws<ArgumentNullException>(action);
Assert.Equal(nameof(builder), exception.ParamName);
}

[Fact]
public void WithDataVolumeShouldThrowsWhenBuilderIsNull()
public void WithDataVolumeShouldThrowWhenBuilderIsNull()
{
IResourceBuilder<RedisResource> builder = null!;

var action = () => builder.WithDataVolume();

Assert.Multiple(() =>
{
var exception = Assert.Throws<ArgumentNullException>(action);
Assert.Equal(nameof(builder), exception.ParamName);
});
var exception = Assert.Throws<ArgumentNullException>(action);
Assert.Equal(nameof(builder), exception.ParamName);
}

[Fact]
public void WithDataBindMountShouldThrowsWhenBuilderIsNull()
public void WithDataBindMountShouldThrowWhenBuilderIsNull()
{
IResourceBuilder<RedisResource> builder = null!;
const string source = "/data";

var action = () => builder.WithDataBindMount(source);

Assert.Multiple(() =>
{
var exception = Assert.Throws<ArgumentNullException>(action);
Assert.Equal(nameof(builder), exception.ParamName);
});
var exception = Assert.Throws<ArgumentNullException>(action);
Assert.Equal(nameof(builder), exception.ParamName);
}

[Fact]
public void WithDataBindMountShouldThrowsWhenNameIsNull()
public void WithDataBindMountShouldThrowWhenNameIsNull()
{
var distributedApplicationBuilder = new DistributedApplicationBuilder([]);
const string name = "Redis";
var resource = new RedisResource(name);
var builder = distributedApplicationBuilder.AddResource(resource);
var builder = TestDistributedApplicationBuilder.Create();
var redis = builder.AddRedis("Redis");
string source = null!;

var action = () => builder.WithDataBindMount(source);
var action = () => redis.WithDataBindMount(source);

Assert.Multiple(() =>
{
var exception = Assert.Throws<ArgumentNullException>(action);
Assert.Equal(nameof(source), exception.ParamName);
});
var exception = Assert.Throws<ArgumentNullException>(action);
Assert.Equal(nameof(source), exception.ParamName);
}

[Fact]
public void WithPersistenceShouldThrowsWhenBuilderIsNull()
public void WithPersistenceShouldThrowWhenBuilderIsNull()
{
IResourceBuilder<RedisResource> builder = null!;

var action = () => builder.WithPersistence();

Assert.Multiple(() =>
{
var exception = Assert.Throws<ArgumentNullException>(action);
Assert.Equal(nameof(builder), exception.ParamName);
});
var exception = Assert.Throws<ArgumentNullException>(action);
Assert.Equal(nameof(builder), exception.ParamName);
}

#endregion

#region RedisCommanderConfigWriterHook

[Fact]
public async Task AfterEndpointsAllocatedAsyncShouldThrowsWhenDistributedApplicationModelIsNull()
public async Task AfterEndpointsAllocatedAsyncShouldThrowWhenDistributedApplicationModelIsNull()
{
DistributedApplicationModel appModel = null!;
var cancellationToken = CancellationToken.None;
Expand All @@ -153,35 +128,29 @@ public async Task AfterEndpointsAllocatedAsyncShouldThrowsWhenDistributedApplica
#region RedisCommanderResource

[Fact]
public void CtorRedisCommanderResourceShouldThrowsWhenNameIsNull()
public void CtorRedisCommanderResourceShouldThrowWhenNameIsNull()
{
string name = null!;

var action = () => new RedisCommanderResource(name);

Assert.Multiple(() =>
{
var exception = Assert.Throws<ArgumentNullException>(action);
Assert.Equal(nameof(name), exception.ParamName);
});
var exception = Assert.Throws<ArgumentNullException>(action);
Assert.Equal(nameof(name), exception.ParamName);
}

#endregion

#region RedisResource

[Fact]
public void CtorRedisResourceShouldThrowsWhenNameIsNull()
public void CtorRedisResourceShouldThrowWhenNameIsNull()
{
string name = null!;

var action = () => new RedisResource(name);

Assert.Multiple(() =>
{
var exception = Assert.Throws<ArgumentNullException>(action);
Assert.Equal(nameof(name), exception.ParamName);
});
var exception = Assert.Throws<ArgumentNullException>(action);
Assert.Equal(nameof(name), exception.ParamName);
}

#endregion
Expand Down