[tests] Work around sqlserver 2022-latest latest image breaking with testcontainers#5058
Merged
radical merged 2 commits intomicrosoft:mainfrom Jul 24, 2024
Merged
Conversation
ghost
added
the
area-codeflow
joperezr
reviewed
Jul 24, 2024
...ityFrameworkCore.SqlServer.Tests/Aspire.Microsoft.EntityFrameworkCore.SqlServer.Tests.csproj
Outdated
Show resolved
Hide resolved
radical
added
area-integrations
.. with testcontainers because the path `/opt/mssql-tools/bin/sqlcmd` changed to `/opt/mssql-tools18/bin/sqlcmd`. But this hardcoded path is being used in testcontainers, causing it to fail. testcontainers/testcontainers-dotnet#1220 microsoft/mssql-docker#892
radical
force-pushed
the
disable-efcore-sqlserver
branch
from
b3a5b7a to
9288833
Compare
radical
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[tests] Workaround sqlserver 2022-latest latest image failing
.. with testcontainers because the path
/opt/mssql-tools/bin/sqlcmdchanged to
/opt/mssql-tools18/bin/sqlcmd. But this hardcoded path isbeing used in testcontainers, causing it to fail.
testcontainers/testcontainers-dotnet#1220
microsoft/mssql-docker#892
Issue: #5057
Microsoft Reviewers: Open in CodeFlow