Merged
Conversation
Remove some extra `BuiltInMeters()` code that snuck in after microsoft#1948.
ghost
added
the
needs-area-label
dotnet-policy-service
bot
added
the
community-contribution
eerhardt
reviewed
Mar 14, 2024
Apply review feedback.
eerhardt
reviewed
Mar 14, 2024
| //.AddGrpcClientInstrumentation() | ||
| .AddHttpClientInstrumentation() | ||
| // Add instrumentation for the AWS .NET SDK. | ||
| .AddAWSInstrumentation(); |
Contributor
Author
There was a problem hiding this comment.
Sorry - copy-paste fail.
Comment on lines
+68
to
+69
| // Uncomment the following line to enable gRPC instrumentation (requires the OpenTelemetry.Instrumentation.GrpcNetClient package) | ||
| //.AddGrpcClientInstrumentation() |
Member
There was a problem hiding this comment.
Since the TestShop does in fact use Grpc, can we keep this one? That way we get the right tracing in the TestShop.
- Add gRPC back to the test shop. - Remove incorrect AWS references.
Put it back so it builds...
Add another one back.
- Remove OpenTelemetry.Instrumentation.Process from Directory.Packages.props - Sync a few more ServiceDefaults with the template
eerhardt
approved these changes
Mar 15, 2024
Member
eerhardt
left a comment
eerhardt
left a comment
There was a problem hiding this comment.
LGTM. Thanks for the contribution!
github-actions
bot
added
area-integrations
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove some extra
BuiltInMeters()code that snuck in after #1948.Microsoft Reviewers: Open in CodeFlow