Repository navigation
Fix signing failures for dashboard SDK packages - #20027
Conversation
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 20027Or
iex "& { $(irm https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 20027" |
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
🟢 Approval recommended
The mappings are complete, unique, and consistent with existing third-party signing rules.
Pull request overview
Adds missing third-party signing classifications for Dashboard dependencies to prevent SIGN004 failures.
Changes:
- Maps Dapper, OpenTelemetry ASP.NET Core instrumentation, and SQLitePCLRaw assemblies to
3PartySHA2.
File summaries
| File | Description |
|---|---|
eng/Signing.props |
Adds third-party certificate mappings for Dashboard assemblies. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Balanced
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
Tests selector1 / 99 PR test projects · 0 PR jobs · 0 advisory-only targets, from 1 changed file. Selected PR test projects (1 / 99)
Selected PR jobs (0)none Advisory workflow impact (0)none How these were chosen — grouped by what changed📄 Job reasonsnone Selection computed for commit |
|
✅ No documentation update needed. Step 5 branch taken:
|
|
The CI build failed due to test failure(s) that appear unrelated to the PR changes. These may be flaky tests. Suspected flaky test(s):
Suggested actions:
You can re-run the failed jobs from the workflow run page. |
Description
Failure: The manual internal build for #19999 failed in the Windows Build signing step: build 3071407.
Why: Dashboard persistence added in #18924 brought Dapper, OpenTelemetry instrumentation, and SQLite binaries into the
Aspire.Dashboard.Sdk.*package payloads. These files had no explicit rules ineng/Signing.props, so Arcade assigned its defaultMicrosoft400certificate and rejected the third-party assemblies.The failure did not appear on
mainbecause automaticmainbuilds usePostBuildSign=true. Arcade consequently omits managed NuGet packages from the signing inputs, and the current rolling publishing flow does not add another managed-package signing step.Manual and release builds use
PostBuildSign=false, which recursively signs and validates managed NuGet package contents. The manual build therefore exercised the release signing path and caught a failure that would also occur in a release build.Fix: Classify the affected dashboard dependencies as
3PartySHA2, consistent with the repository's other third-party binaries.Fixes # (issue)
Checklist
<remarks />and<code />elements on your triple slash comments?