[release/13.5] Mark Radius provider builders experimental - #19874
Damian Edwards (DamianEdwards) merged 1 commit into
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 1d99830a-efcc-4318-8377-49a565359d78
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 19874Or
iex "& { $(irm https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 19874" |
Tests selector (audit mode)The full test matrix and all jobs still run in audit mode. The tests and jobs below are what selective CI would run under enforcement. 1 / 100 test projects · 2 jobs, from 4 changed files. Selected test projects (1 / 100)
Selected jobs (2)
How these were chosen — grouped by what changed🔧 🔧 🔧 🔧 Job reasons
Selection computed for commit |
There was a problem hiding this comment.
🟢 Approval recommended
The focused metadata changes consistently apply the existing diagnostic without affecting runtime behavior.
Pull request overview
Aligns Radius cloud-provider callback contracts with the existing experimental API boundary.
Changes:
- Marks AWS and Azure provider interfaces experimental.
- Applies the same diagnostic to internal implementations.
File summaries
| File | Description |
|---|---|
IAzureRadiusProviderBuilder.cs |
Marks the Azure callback contract experimental. |
IAwsRadiusProviderBuilder.cs |
Marks the AWS callback contract experimental. |
AzureRadiusProviderBuilder.cs |
Marks the internal Azure implementation experimental. |
AwsRadiusProviderBuilder.cs |
Marks the internal AWS implementation experimental. |
Review details
- Files reviewed: 4/4 changed files
- Comments generated: 0
- Review effort level: Balanced
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
557ad01
into
release/13.5
|
✅ No documentation update needed. Step 5 branch taken: Triggered signals (1): Exclusion reasons (from signals.json): base branch is |
|
Thank you! |
Description
Marks the Radius AWS and Azure cloud-provider callback interfaces with
Experimental("ASPIRERADIUS003"), matching theWithAwsProviderandWithAzureProvidermethods that expose them. This keeps consumers from referencing the callback contracts without acknowledging the same experimental stability boundary.The internal provider builder implementations carry the same attribute so their implementation of the experimental contracts compiles without broad warning suppression.
This addresses the issue identified in the review of #19866: #19866 (comment). Generated API baseline files are intentionally unchanged here; #19866 regenerates and pins the release surface separately.
Validation: all 207 tests in
Aspire.Hosting.Radius.Testspass.Fixes # (issue)
Checklist
<remarks />and<code />elements on your triple slash comments?