Skip to content

[release/13.5] Mark Radius provider builders experimental - #19874

Merged
Damian Edwards (DamianEdwards) merged 1 commit into
release/13.5from
sebros/add-radius-provider-experimental-attribu
Sep 2, 2026
Merged

Damian Edwards (DamianEdwards) merged 1 commit into
release/13.5from
sebros/add-radius-provider-experimental-attribu

Conversation

@sebastienros

Copy link
Copy Markdown
Contributor

Description

Marks the Radius AWS and Azure cloud-provider callback interfaces with Experimental("ASPIRERADIUS003"), matching the WithAwsProvider and WithAzureProvider methods that expose them. This keeps consumers from referencing the callback contracts without acknowledging the same experimental stability boundary.

The internal provider builder implementations carry the same attribute so their implementation of the experimental contracts compiles without broad warning suppression.

This addresses the issue identified in the review of #19866: #19866 (comment). Generated API baseline files are intentionally unchanged here; #19866 regenerates and pins the release surface separately.

Validation: all 207 tests in Aspire.Hosting.Radius.Tests pass.

Fixes # (issue)

Checklist

  • Is this feature complete?
    • Yes. Ready to ship.
    • No. Follow-up changes expected.
  • Are you including unit tests for the changes and scenario tests if relevant?
    • Yes
    • No
  • Did you add public API?
    • Yes
      • If yes, did you have an API Review for it?
        • Yes
        • No
      • Did you add <remarks /> and <code /> elements on your triple slash comments?
        • Yes
        • No
    • No
  • Does the change make any security assumptions or guarantees?
    • Yes
      • If yes, have you done a threat model and had a security review?
        • Yes
        • No
    • No

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Copilot-Session: 1d99830a-efcc-4318-8377-49a565359d78
Copilot AI balanced review requested due to automatic review settings September 2, 2026 19:21
@github-actions

github-actions Bot commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

🚀 Dogfood this PR with:

⚠️ WARNING: Do not do this without first carefully reviewing the code of this PR to satisfy yourself it is safe.

curl -fsSL https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 19874

Or

  • Run remotely in PowerShell:
iex "& { $(irm https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 19874"

@github-actions github-actions Bot added the area-integrations Issues pertaining to Aspire Integrations packages label Sep 2, 2026
@github-actions

github-actions Bot commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

Tests selector (audit mode)

The full test matrix and all jobs still run in audit mode. The tests and jobs below are what selective CI would run under enforcement.

1 / 100 test projects · 2 jobs, from 4 changed files.

Selected test projects (1 / 100)

Aspire.Hosting.Radius.Tests

Selected jobs (2)

extension-e2e, typescript-api-compat


How these were chosen — grouped by what changed

🔧 src/Aspire.Hosting.Radius/CloudProviders/AwsRadiusProviderBuilder.cs (changed source)
1 directly: Aspire.Hosting.Radius.Tests

🔧 src/Aspire.Hosting.Radius/CloudProviders/AzureRadiusProviderBuilder.cs (changed source)
1 directly: Aspire.Hosting.Radius.Tests

🔧 src/Aspire.Hosting.Radius/CloudProviders/IAwsRadiusProviderBuilder.cs (changed source)
1 directly: Aspire.Hosting.Radius.Tests

🔧 src/Aspire.Hosting.Radius/CloudProviders/IAzureRadiusProviderBuilder.cs (changed source)
1 directly: Aspire.Hosting.Radius.Tests

Job reasons

Job Triggered by
extension-e2e src/Aspire.Hosting.Radius/CloudProviders/AwsRadiusProviderBuilder.cs, src/Aspire.Hosting.Radius/CloudProviders/AzureRadiusProviderBuilder.cs, src/Aspire.Hosting.Radius/CloudProviders/IAwsRadiusProviderBuilder.cs, src/Aspire.Hosting.Radius/CloudProviders/IAzureRadiusProviderBuilder.cs
• affected project Aspire.Hosting.Radius
typescript-api-compat affected project Aspire.Hosting.Radius

Selection computed for commit 1b7dcb0.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The focused metadata changes consistently apply the existing diagnostic without affecting runtime behavior.

Pull request overview

Aligns Radius cloud-provider callback contracts with the existing experimental API boundary.

Changes:

  • Marks AWS and Azure provider interfaces experimental.
  • Applies the same diagnostic to internal implementations.
File summaries
File Description
IAzureRadiusProviderBuilder.cs Marks the Azure callback contract experimental.
IAwsRadiusProviderBuilder.cs Marks the AWS callback contract experimental.
AzureRadiusProviderBuilder.cs Marks the internal Azure implementation experimental.
AwsRadiusProviderBuilder.cs Marks the internal AWS implementation experimental.
Review details
  • Files reviewed: 4/4 changed files
  • Comments generated: 0
  • Review effort level: Balanced

💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.

@sebastienros

Copy link
Copy Markdown
Contributor Author

Nell Shamrell-Harrington (@nellshamrell) Mitch Denny (@mitchdenny)

@DamianEdwards
Damian Edwards (DamianEdwards) merged commit 557ad01 into release/13.5 Sep 2, 2026
344 checks passed
@DamianEdwards
Damian Edwards (DamianEdwards) deleted the sebros/add-radius-provider-experimental-attribu branch September 2, 2026 22:54
@github-actions github-actions Bot added this to the 13.5.x milestone Sep 2, 2026
@aspire-repo-bot

Copy link
Copy Markdown
Contributor

✅ No documentation update needed.

Step 5 branch taken: excluded → base_branch_is_release, title_release_prefix (backport exclusion — checked first, overrides recommendation).

Triggered signals (1): experimental_attribute_added — evidence: [Experimental("ASPIRERADIUS003", ...)] added to AwsRadiusProviderBuilder.cs, AzureRadiusProviderBuilder.cs, IAwsRadiusProviderBuilder.cs, IAzureRadiusProviderBuilder.cs.

Exclusion reasons (from signals.json): base branch is release/13.5 and PR title is prefixed [release/13.5] — this is a backport PR. The PR body confirms it addresses feedback from the original PR #19866, which is the forward change on the default branch; documentation (if any) belongs to that originating PR, not this backport. Per workflow rules, excluded == true overrides recommendation (docs_optional) and no docs PR is drafted.

@nellshamrell

Copy link
Copy Markdown
Contributor

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-integrations Issues pertaining to Aspire Integrations packages

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants