Revert state column badge changes#1957
Merged
davidfowl merged 4 commits intomicrosoft:release/8.0-preview3from Jan 30, 2024
Merged
Revert state column badge changes#1957davidfowl merged 4 commits intomicrosoft:release/8.0-preview3from
davidfowl merged 4 commits intomicrosoft:release/8.0-preview3from
Conversation
ghost
added
the
|
|
||
| @if (_unviewedCount > 0) | ||
| { | ||
| <FluentAnchor aria-label="@(_unviewedCount == 1 ? nameof(Columns.UnreadLogErrorsBadgeOneErrorLog) : string.Format(Loc[nameof(Columns.UnreadLogErrorsBadgeErrorLogs)], _unviewedCount))" |
There was a problem hiding this comment.
Thanks for taking accessibility into consideration with the fix!
kvenkatrajan
approved these changes
Jan 29, 2024
davidfowl
approved these changes
Jan 30, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re-adds the old badge into the state column, but always makes the text color white so that there's consistent contrast on both themes. Also slightly darkens --error in dark theme (increases contrast with the white text, and looks better while still maintaining sufficient contrast with background)
Microsoft Reviewers: Open in CodeFlow
Fixes #1926
(dependent on #1955 approval)